Add cdp type from auto_generate_cdp crate

Vrtgs / thirtyfour

Selenium WebDriver client for Rust, for automated testing of websites

Other

1.06k stars 78 forks source link

Add cdp type from auto_generate_cdp crate #202

Closed Noirkelo closed 8 months ago

Noirkelo commented 8 months ago

it seem should be easy to do so (i build cdp type in other crate just for my case). Perhaps we could have a stronge type backend CDP command and with nice return?

stevepryde commented 8 months ago

This crate already has basic support for CDP. My intention is to expand what is there. I'm not sure what another wrapper around this wrapper would achieve. You could provide a wrapper around WebDriver in your crate, perhaps?

I don't want to add another third party dependency for things like this for now, if possible.

Noirkelo commented 8 months ago

I just want to run cdp comand and get the command return in a Result<...> current just a Value. And after post issue i found auto_generate_cdp is too heavy it will take a lot of compile time(Which i found in rust-headless-chrome). So you're right when i post this issue i dont think too much. Add this addtion crate dont make any sence. Anyway thank for you great job to maintain this crate