codepathreview
commented
7 years ago :+1: Good work getting all required and few optional stories done. A few notes after checking out the code:
- Good layout, proper view naming, usage of sp/dp, margin and relative placement rules
- Good job on a decent UI
- Good job using the ViewHolder pattern to improve performance in
ListView. - Good job implementing heterogeneous list view
- Consider including a check to see if internet is available to detect any network failures. Show an appropriate message in case of failure.
- Consider implementing Recycler View instead of ListView
- Consider better organizing your source files
We have provided a detailed Project 1 Feedback Guide here which covers the most common points we see for this project. Read through the feedback guide point-by-point to determine other ways you could improve your submission. You should consider going back and implementing applicable feedback as well. Keep in mind that one of the most important parts of Android development is learning the correct patterns and conventions. Hopefully this first project has given you a better sense of working with RelativeLayout which is a very flexible layout system, probably one of the most powerful responsive-first layout systems available across web and mobile platforms. This assignment also gave us our first introduction to networking, working with APIs and loading remote images. The next assignment will introduce new concept such as accepting user input and navigating between activities but will also reinforce important concepts such as networking, using APIs, handling remote images.
If you have any particular questions about the assignment in general or on any of the feedback, feel free to reply here or or email us support@codepath.com.
P.S. Good to see you properly added the README with features and GIF to your project as described in the submitting assignments guide! /cc @codepathreview
@Vsin pls upload GIF for your submission and update status here