search

VsixCommunity / Community.VisualStudio.Toolkit.DependencyInjection

Adds Dependency Injection tooling for the Community.VisualStudio.Toolkit
Other
14 stars 8 forks source link

Publish packages to NuGet #2

Closed StevenRasmussen closed 2 years ago

StevenRasmussen commented 3 years ago

@madskristensen - Any chance you can help with getting the CI/CD process setup for this repo so that packages are produced/published to NuGet?

madskristensen commented 3 years ago

yup, i can do that part

StevenRasmussen commented 3 years ago

@madskristensen - bump ;) Thanks

madskristensen commented 3 years ago

Yikes, sorry I forgot. I'll take a look soon, but currently out on leave

StevenRasmussen commented 3 years ago

No worries. Just wanted to keep it on your radar 😃

StevenRasmussen commented 2 years ago

Hi @madskristensen - Just following up on this. Thanks!

madskristensen commented 2 years ago

Would it make sense if the package inherited from TookitPackage?

StevenRasmussen commented 2 years ago

It would... and it does 😃 . See here.

madskristensen commented 2 years ago

It's now publishing to NuGet. There are output warnings about no content in the 'lib' folder and I also noticed that it isn't referencing the latest Toolkit packages (should use Community.VisualStudio.Toolkit..

See build details here: https://ci.appveyor.com/project/madskristensen/community-visualstudio-toolkit-dependencyinjection

StevenRasmussen commented 2 years ago

Awesome! I'll take a look at those issues. Also, it looks like it would probably be a good idea to follow the same naming convention and NuGet publishing strategy as the main toolkit, ie:

Community.VisualStudio.Toolkit.DependencyInjection.Core.14 Community.VisualStudio.Toolkit.DependencyInjection.Core.15 ... and Community.VisualStudio.Toolkit.DependencyInjection.Microsoft.14 Community.VisualStudio.Toolkit.DependencyInjection.Microsoft.15 ...

I'll update the projects so that they are named correctly. Thanks again!