search

VsixCommunity / Community.VisualStudio.Toolkit

Making it easier to write Visual Studio extensions
Other
256 stars 44 forks source link

SelectionEvents.SelectionChanged does not fire due to exception in OnSelectionChanged in specific cases #426

Open Jo8n opened 1 year ago

Jo8n commented 1 year ago

When the user selects a solution or a project after having selected the solution, an exception occurs in SolutionItem.FromHierarchy as called from SelectionEvents.OnSelectionChanged.

Would suggest changing these two lines in SelectionEvents.OnSelectionChanged: SolutionItem? from = SolutionItem.FromHierarchy(pHierOld, itemidOld); SolutionItem? to = SolutionItem.FromHierarchy(pHierNew, itemidNew); to: SolutionItem? from = pHierOld == null ? null : SolutionItem.FromHierarchy(pHierOld, itemidOld); SolutionItem? to = pHierNew == null ? null : SolutionItem.FromHierarchy(pHierNew, itemidNew);

As an aside, thanks for a great toolkit!