VsixCommunity / Community.VisualStudio.Toolkit

Making it easier to write Visual Studio extensions
Other
256 stars 44 forks source link

Skipped the Newtonsoft.Json version when using the newer VS SDK. #438

Closed reduckted closed 1 year ago

reduckted commented 1 year ago

Fixes #434

Two changes:

  1. If the Microsoft.VisualStudio.SDK package is greater than the most recent 17.5 version (which means it is 17.6.36389 or above), then the Newtonsoft.Json version check is skipped because NuGet will raise warnings if the version of Newtonsoft.Json is higher than it should be.
  2. Setting the build property CheckNewtonsoftJsonVersion to true will completely skip the version check, just in case you don't want it to run for whatever reason.
madskristensen commented 1 year ago

Awesome. Thank you!!