search

VsnGamer / ElevatorMod

Port of the elevator from OpenBlocks for Minecraft 1.8+
https://minecraft.curseforge.com/projects/openblocks-elevator
MIT License
23 stars 23 forks source link

Camouflage still does not work in 1.20.1 #123

Open lawd17 opened 9 months ago

lawd17 commented 9 months ago

Right-clicking on the elevator with a block does not change its appearance. I am using elevatorid-1.20.1-lex-1.9 in a modpack, Better MC [FORGE] - BMC4 .

VsnGamer commented 9 months ago

Do you have any logs? What's the specific Forge version you are running? Does it happen with any block?

lawd17 commented 9 months ago

It does not work with any block, even basic minecraft blocks. It only makes the sound but you don't change the appearance.

Here is the version I am using on the server.

minecraft_server_info

VsnGamer commented 9 months ago

Cannot reproduce, tried with Forge 47.2.16. Can you send the server and client logs?

lawd17 commented 9 months ago

Those are the last logs. latest_client.log latest_server.log

ThePhiRatio commented 6 months ago

I am having the same issue in the same modpack.

VsnGamer commented 6 months ago

This and #124 seem related, I'll try to upload a potential fix later.

happymoep commented 5 months ago

This and #124 seem related, I'll try to upload a potential fix later.

Any update on this? I've been having the same issue with BMC4. Camouflaging a block does apply it in the background, it's just not showing visual change.

VsnGamer commented 5 months ago

I still can't reproduce this.

I've build this with Forge 1.20.1 - 47.2.20, can someone try it in that modpack? elevatorid-1.20.1-1.9.1-forge.jar.zip

happymoep commented 5 months ago

Thanks for the swift reply!

I have replaced the "elevatorid-1.20.1-lex-1.9.jar" from the modpack with the "elevatorid-1.20.1-1.9.1-forge.jar" you provided and in a new test world still have the same issue. I am running BMC4 release "Better MC [FORGE] 1.20.1 v26" with MC 1.20.1 and Forge 47.2.17 from the curseforge launcher.

I am available on Discord as happymoep in case you seek instant communication

EDIT: Dumping all the mods of that modpack into a new profile (essentially purging all configs) leads to camouflage working as expected. While this seems to make it "not your problem" any pointers as to what I could try to find out what causes the incompatibility are greatly appreciated. I'd really like to get camouflage working or at least be able to teleport to an elevator that is covered by non-full-blocks like carpet or slabs.

VsnGamer commented 5 months ago

It seems to be related with ModernFix's Dynamic Resources being enabled by default in that modpack.

As a workaround, you can disable it. In the meantime I'll try to make it compatible with it as that option seems really nice for memory usage.

nicocraft31 commented 5 months ago

Can also confirm in 1.19.2 ("elevatorid-1.19.2-1.8.9", Forge 43.3.5, with a custom modpack), fixed when disabling ModernFix's mixin.perf.dynamic_resources. The arrow also does not show when dynamic_resources in on.

Basically, this (seems to) happen in all versions of the mod & MC.