search

Vswe / ModJam3

27 stars 53 forks source link

Ore Dict unification #48

Open DrSilix opened 10 years ago

DrSilix commented 10 years ago

this would be nice in an output node or a separate node, an option under filter when using the ore dict type to unify ores/ingots/etc to the type selected.

Vswe commented 10 years ago

Seems a bit wrong if you ask me, just because some items count as the same thing in crafting doesn't mean they are interchangeable. For instance, different types of wood or saplings, some types are quite rare while the normal types are super common.

DrSilix commented 10 years ago

hmm isn't that fuzzy detection like metadata, i thought ore dictionary entries that are entered under the same name are the relative exact same item. if that isn't true then maybe just ingots/gems maybe ores

Vswe commented 10 years ago

Well, every item that should be interchangeable when it comes to recipes don't have to interchangeable in a conversion. For instance, if you want to use a blue color from another mod it doesn't mean that you want it to be able to be converted to lapiz.

DrSilix commented 10 years ago

yea definately, there are mods which offer a simple craft unification of say dye's and run into that stuff but they usually have configs, stuff like that i would think would be black listed through a config. wouldn't have to even be at creation time, just implement the simple unification, with some common blacklists such as ink sacs, lapis, bone meal and see what comes up in testing. that or simply limit it to ores, but thats no fun.

Vswe commented 10 years ago

I don't think this suggestion is something I can add in a reasonable way.

esotericist commented 10 years ago

This is a pretty big hole in the current usage of 'oredict'. There have been incidents of converting between things that aren't logically equivalent to get 'better' materials. (combs, etc)

Until we have better infrastructure in forge for specifying "is completely equivalent to" as separate from "counts as for crafting purposes", this is hazardous space.

(edit to remove mistaken assertion about JABBA and bees)

DrSilix commented 10 years ago

ok, i was just suggesting it because i started a new survival world with a focus on SFM and rotarycraft and this is one of the things i've ran into and needed, i can use a minefactory unifier with sfm just as easy.