VtEcostudies / VAL_Data_Explorers

Other
1 stars 1 forks source link

Conflicting stylesheets #7

Open MortenHofft opened 1 year ago

MortenHofft commented 1 year ago
Screenshot 2022-09-05 at 10 22 52

The site has a somewhat aggresive global styling on headers. Since the header tag is legal to reuse (and is also used by the data explorer), then I think it makes sense to limit the sites style scope.

The site style says:

@media screen and (min-width: 950px)
header {
    display: block;
    position: fixed;
    top: 0;
    left: auto;
    width: 100%;
    overflow: visible;
    background: #fff;
    border-bottom: 1px solid #c3c3c3;
    z-index: 50000;
}

witch hides the header on map list

jloomisVCE commented 1 year ago

Thanks for finding this issue. I see this problem and I agree styling should have proper scope. Our WP site is managed by an outside contractor. (My changes for the GBIF explorer are unusual.) I'm interested in any recommendations you have on how to remedy this.

MortenHofft commented 1 year ago

I would just add a class to the header. And then style on that instead. So instead of <header role="banner"> do <header role="banner" class="site-header">

And then in header.scss do

.site-header {  // instead of styling on the header tag
    display: none;

I'm fairly certain that the style isn't used anywhere else on your site given how it is styled. So I would guess that would have no unforeseen consequences