search

VueGWT / vue-gwt

Vue.js Components/Custom Elements in Java with GWT. Developed at https://www.genmymodel.com.
https://vuegwt.github.io/vue-gwt/
MIT License
204 stars 46 forks source link

add methods from interfaces of components to template parser #121

Closed thelsing closed 2 years ago

thelsing commented 2 years ago

This way one can implement things like i18n with default methods in interfaces.

adrienbaron commented 2 years ago

Happy new year! And thank you for the PR! Could you try and add an test for this in the test Maven module? This would help us make sure this works at runtime when GWT compiles the code to JS 😊.

You can see CONTRIBUTING.md for details about the tests and how to run them 👍

thelsing commented 2 years ago

I added a method to test generation of calls to default methods of interfaces.

thelsing commented 2 years ago

I used JDK11 because on JDK17 some test fail on JDK17 and 16

adrienbaron commented 2 years ago

I had a look at your test and that's not really what I had in mind 😅, those tests are more "unit" level and don't ensure the code actually works at runtime in a browser once GWT converted to JS.

I took the liberty of writting something closer to what I had in mind 👍 . I pushed it on your branch by mistake instead of a branch on my repo xD, I hope thats OK, tell me if you're happy for me to merge 👍

thelsing commented 2 years ago

It's good that you added the test. I'm afraid it would have taken much more time for me. For me it's fine to merge it.