search

VueTubeApp / VueTube

A simple FOSS video streaming client aimed to recreate ALL features from their respective apps (and more)
GNU General Public License v3.0
3.27k stars 171 forks source link

Readme Banner Changes and ReadMe Cleanup #426

Closed xafn closed 2 years ago

404-Program-not-found commented 2 years ago

hmm, I'm not so sure about that banner. @Frontesque what do you think?

xafn commented 2 years ago

hmm, I'm not so sure about that banner. @Frontesque what do you think?

Hmm then I can change the existing banner's text to #00dcc8 so that it is visible in both light and dark mode if you want.

404-Program-not-found commented 2 years ago

No, it's not the color per se. The overall design doesn't seem to fit a big banner imo

xafn commented 2 years ago

No, it's not the color per se. The overall design doesn't seem to fit a big banner imo

Sorry I meant change the banner we have already on the readme to #00dcc8

404-Program-not-found commented 2 years ago

Personally, I don't think a change in the banner is really needed. However, it should be noted that GH now supports a new feature, that being dark and light mode images

<picture>
  <source media="(prefers-color-scheme: dark)" srcset="https://user-images.githubusercontent.com/25423296/163456776-7f95b81a-f1ed-45f7-b7ab-8fa810d529fa.png">
  <source media="(prefers-color-scheme: light)" srcset="https://user-images.githubusercontent.com/25423296/163456779-a8556205-d0a5-45e2-ac17-42d089e3c3f8.png">
  <img alt="Shows an illustrated sun in light color mode and a moon with stars in dark color mode." src="https://user-images.githubusercontent.com/25423296/163456779-a8556205-d0a5-45e2-ac17-42d089e3c3f8.png">
</picture>
xafn commented 2 years ago

Oh, that's news to me. I'll do that then in a different PR later.