VueTubeApp / VueTube

A simple FOSS video streaming client aimed to recreate ALL features from their respective apps (and more)
GNU General Public License v3.0
3.28k stars 170 forks source link

versionCode is never increased #535

Closed IzzySoft closed 1 year ago

IzzySoft commented 1 year ago

Steps to reproduce

Just run aapt d badging VueTube-Canary-0.4.2.apk to see it's still set to 1:

package: name='com.Frontesque.vuetube' versionCode='1' versionName='0.4.2' compileSdkVersion='30' compileSdkVersionCodename='11'

Expected behavior

versionCode is increased with each release, so Android considers the new APK being an update to the installed app.

Actual behavior

No update notification as Android considers the new APK being the same version.

VueTube version

0.4.2

Android version

Android 11

Device

all

Other details

No response

Acknowledgements

Frontesque commented 1 year ago

The version code will be incremented once we hit version 1.0.

IzzySoft commented 1 year ago

Thanks – but why not starting now? Without that, those who prefer using an F-Droid client to manage their apps (VueTube is available here) will never receive update notifications before you reach 1.0 – and each update in the repo would overwrite the previous version (instead of multiple versions being available). As pointed out, versionCode is what Android uses to tell versions apart, so it's crucial to increase that whenever propagating a new version.

Just wondering and suggesting – I will of course respect your decision.

IzzySoft commented 1 year ago

@Frontesque currently, you app is never updated in my repo (and neither on the devices of most people) as versionCode is still set to 1. My updater won't even find the latest version as you've attached a ZIP there instead of an APK. Further, currently it doesn't really look like 1.0 will ever be reached as there are no more commits since July. So may I ask what your plans are?

Frontesque commented 1 year ago

I didn't build the latest version. My life has been too crazy to work on this and it seems like the rest of the team that was working on it has stopped.

IzzySoft commented 1 year ago

Ouch… So who has the signing keys? Can you build & sign (and will you)? No pressure, I just want to figure how to continue.