Vuepic / vue-datepicker

Datepicker component for Vue 3
https://vue3datepicker.com
MIT License
1.44k stars 143 forks source link

auto-apply not working in custom flow mode #465

Closed marco-gagliardi closed 1 year ago

marco-gagliardi commented 1 year ago

Describe the bug

https://github.com/Vuepic/vue-datepicker/assets/2972151/482e7bfc-23ca-4bc9-889d-922bc2d3b00c

To Reproduce Link to code: https://stackblitz.com/edit/vuepic-vue-datepicker-bvfxyf?file=src%2Fcomponents%2FPlayground.vue

  1. provide a custom flow array and set auto apply property
  2. click to open the overlay popup
  3. click on the toggle button
  4. click on a date
  5. nothing happens and user is stuck

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop & mobile (please complete the following information):

marco-gagliardi commented 1 year ago

hey @Jasenkoo any ETA for this fix to be released? Thanks

Jasenkoo commented 1 year ago

Somewhere mid August

dathacky commented 1 year ago

Its still not work :( @Jasenkoo Expected: Input reset to default date when blur input. https://www.awesomescreenshot.com/video/19966799?key=4e19f5ec5dff001e4c2a9275258cb6a8

Jasenkoo commented 1 year ago

@dathacky Are you calling a provided onInput function from the slot?

dathacky commented 1 year ago

@dathacky Are you calling a provided onInput function from the slot?

yeah :( I tried using onInput and the value appears invalid date if my input value is null @Jasenkoo

Jasenkoo commented 1 year ago

@dathacky This is a wrong issue, I added a comment to an original ticket

marco-gagliardi commented 1 year ago

hey @Jasenkoo FYI: I did a quick test upgrading the version on the same example code and it looks like the "auto-apply not working" bug is still happening (the overlap icon one is solved tho)

https://github.com/Vuepic/vue-datepicker/assets/2972151/6f72057a-f92e-4cce-8bbb-2bf043fedd50

Jasenkoo commented 1 year ago

@marco-gagliardi This is intended behavior, you need to pass partial-flow too. Example

marco-gagliardi commented 1 year ago

thanks @Jasenkoo. With partial-flow it actually sets the value when a day is clicked in your example, however the calendar box doesn't close automatically right after (as it would be expected to happen using auto-apply)