search

Vuepic / vue-datepicker

Datepicker component for Vue 3
https://vue3datepicker.com
MIT License
1.43k stars 142 forks source link

Aria issue on aria-dialog for time picker #941

Closed endorphines closed 1 month ago

endorphines commented 1 month ago

Describe the bug Our accessibility scanner reports that when the time picker dialogs are open, there is no aria-label, and throws a violation for ARIA dialog and alertdialog nodes should have an accessible name. I tried to see if there is an existing matching aria-label but doesn't seem to be available.

To Reproduce Run any accessibility scanner when the time picker dialog is opened.

Expected behavior To have aria-label on time picker dialogs or allow us to set aria-labels for time picker dialogs

Screenshots Screenshot 2024-07-15 at 1 53 58 PM

Desktop & mobile (please complete the following information):

Thank you!

Jasenkoo commented 1 month ago

Already added, will be in the next release, there are quite a few accessibility improvements

endorphines commented 1 month ago

That's awesome! Will be waiting for the next release. Thank you very much!