search

VulcanJS / Vulcan-Starter

VulcanJS starter repo. Use as a base for your own VulcanJS projects.
MIT License
127 stars 88 forks source link

step 12 displayName not displayed #138

Closed DylanKojiCheslin closed 4 years ago

DylanKojiCheslin commented 4 years ago

on the "devel" branch on step 12 the displayName is never shown and the following steps don't render as intended.

seen on a two repo installation with both on "devel" branch at 1.14.0 OS: Ubuntu 18.04.3 LTS

bug example repo: https://github.com/DylanKojiCheslin/step12Bug

DylanKojiCheslin commented 4 years ago

https://github.com/DylanKojiCheslin/step12Bug/blob/devel/Screenshot%20from%202019-11-20%2006-42-22.png

lucassardois commented 4 years ago

Same problem here, no errors and warnings in the console.

eric-burel commented 4 years ago

Sorry I try to repro based on your code but I am stuck at "Invariant Violation: Could not find "client" in the context or passed in as an option. Wrap the root component in an <ApolloProvider>".

I just updated the starter master branch so 2 repo install is not necessary to test, I just run the app as a 1-repo install

eric-burel commented 4 years ago

I don't have this message on a fresh starter install (but I did not actually test your issue on step 12 yet)

DylanKojiCheslin commented 4 years ago

I tried this on a devel 1-repo setup and it had the same behavior Vulcan 1.14.0, Ubuntu 18.04.3 LTS .

in both cases (1 & 2 repo) I had to manually installed babel with "meteor npm install --save @babel/runtime" due to an error saying bcrypt wasn't installing (this is specfic to Ubuntu afaik). I also have run "npm audit fix" on both so either could be causing the issues that @eric-burel was seeing on my repo but not on the fresh install. Din't see the error He mentioned, it may be related to having different OS?

I will try a 1-repo without the "npm audit fix" but have to do the manual babel install, as it won't build otherwise.

eric-burel commented 4 years ago

Ok I've managed to do a repro. @SachaG I think you wanted the hasOne relation to be implicit, using collection.js addAutoRelations function, but it is not yet used according to your comment. So we need to explicitely add relation: "hasOne" to the field name. Will PR.

eric-burel commented 4 years ago

Can you please check that the change I made in https://github.com/VulcanJS/Vulcan-Starter/pull/143 fixes step 12 for you, so I can close this issue?

DylanKojiCheslin commented 4 years ago

It works, thank you.