Getting-Started tutorial: Step 5 bug in text displayed

VulcanJS / Vulcan-Starter

VulcanJS starter repo. Use as a base for your own VulcanJS projects.

MIT License

127 stars 88 forks source link

Getting-Started tutorial: Step 5 bug in text displayed #22

Closed robeastham closed 4 years ago

robeastham commented 6 years ago

After completing Step 5 the returned text says:

Note that createdAt has an onInsert property, which returns a callback that will set it to the current timestamp whenever a new document is inserted.

However the createdAt only appears in the actual source code and not in the inline version returned to the user the through the webpage. Dashing out the door now and wanted to log here. Will try and figure out why and send a pull request.

SachaG commented 6 years ago

Oh sorry about that, I changed that to use a plain text string to avoid these issues but it looks like I had forgotten to actually push. Can you check again now?

https://github.com/VulcanJS/Vulcan-Starter/blob/master/packages/getting-started/lib/components/other/Schema.jsx

robeastham commented 6 years ago

All good now after pulling and merging master. Thanks Sacha.