search

VulcanJS / Vulcan

🌋 A toolkit to quickly build apps with React, GraphQL & Meteor
http://vulcanjs.org
MIT License
7.98k stars 1.89k forks source link

Swap from react-cookie to js-cookie #1912

Closed justinr1234 closed 6 years ago

SachaG commented 6 years ago

I just used react-cookie for SSR actually, seems to work well. Any reason to switch?

justinr1234 commented 6 years ago

The interface isn’t standard with the JavaScript community

SachaG commented 6 years ago

What's not standard about it? Also it works with SSR, so that's a plus.

justinr1234 commented 6 years ago

@SachaG You fixed it by upgrading to the latest version: https://github.com/VulcanJS/Vulcan/commit/fc67471a38b646064fc728f767e8d8a1d6843903#diff-b9cfc7f2cdf78a7f4b91a753d10865a2

Previously the interface was Cookies.save which doesn't match the standard set and get: https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/cookies/set

But they fixed it in the version you upgraded to, so this ticket is not longer necessary.