VulcanJS / Vulcan

🌋 A toolkit to quickly build apps with React, GraphQL & Meteor
http://vulcanjs.org
MIT License
7.98k stars 1.88k forks source link

Email address verification broken #2038

Closed jimrandomh closed 6 years ago

jimrandomh commented 6 years ago

Email address verification worked in v1.8, and was broken in the process of upgrading to Meteor 1.7.

In meteor:accounts-base, the accounts actions reset-password, verify-email and enroll-account are handled as a group; eg in accounts_server.js and their URLs are defined together. Since Vulcan isn't using hash-style routing and has its own UI, it overrides the routes here and here - but doesn't handle verify-email at all. So email address verification doesn't work; calling Accounts.sendVerificationEmail sends an email with a hash-style URL in it that doesn't work, and rewriting it to a non-hash-style URL doesn't work either.

Apollinaire commented 6 years ago

Hi @jimrandomh , I've worked a bit on the accounts part lately and I will add support for email verification, it is indeed a necesary feature.

Accounts.sendVerificationEmail sends an email with a hash-style URL in it that doesn't work, and rewriting it to a non-hash-style URL doesn't work either.

What have you tried to fix this ? From what I see you need three things to make this work:

jimrandomh commented 6 years ago

https://github.com/VulcanJS/Vulcan/pull/2040