VulcanJS / vulcan-next

The Next starter for GraphQL developers
http://vulcan-docs.vercel.app
MIT License
393 stars 29 forks source link

Server-side callbacks are hiding errors / failing silently #131

Open eric-burel opened 3 years ago

eric-burel commented 3 years ago

Describe the bug

Callback behaviour is not predictible enough.

To Reproduce For instance, I had forgottoen to import crypto in the hashPassword function of the user model.

The user creation callback was failing, but silently :(

Expected behavior

Fail explicitely, except if the callback is specifically marked as failing silently. More broadly, handle server-error correctly => they should return a 500 but should not fail the whole server.