search

VulcanJS / vulcan-npm

The full-stack JavaScript App Framework
https://vulcan-docs.vercel.app
MIT License
31 stars 8 forks source link

fixed nested mdx and files named index #32

Closed Neobii closed 3 years ago

Neobii commented 3 years ago

Adds the ability to have nested mdx docs and handles if they are named index. Also has getFirstHeader to extract the first header out of the mdx to use for autogeneration of head tags.

On vulcan-next, this is how the changes are implemented ...fileName.tsx

eric-burel commented 3 years ago

Thanks! Code sounds ok, could you please add a small test for this? Unit testing would be a bit annoying, lots of mocks etc. so you can maybe add a test folder in the package and create an e2e test with real files? Those file won't be bundled in the published package so that's ok to add a few .md for testing.

eric-burel commented 3 years ago

Closing in favour of https://github.com/VulcanJS/vulcan-npm/pull/51, where we keep the work going based on your commit. Thanks!