search

VulcanWM / discipulis

https://discipulis.vercel.app
GNU Affero General Public License v3.0
4 stars 3 forks source link

feat: added flipper #38

Closed Qudusayo closed 1 year ago

Qudusayo commented 1 year ago
vercel[bot] commented 1 year ago

Someone is attempting to deploy a commit to a Personal Account owned by @VulcanWM on Vercel.

@VulcanWM first needs to authorize it.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
discipulis ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 26, 2023 at 8:42AM (UTC)
VulcanWM commented 1 year ago

Hey dude this is amazing! The only problem is, with this solution, test mode function isn't working anymore. Also is there a way you can explain all the changes you have made?

Qudusayo commented 1 year ago

Hi, Test mode function is working correctly. As shown in the preview video attached to this email.

I added a component that flips and passes it into every child's components with the state managed in the parent component. So when the td element is clicked, it changes the state of the clicked element in the parent component which triggers the flip component for that td to be flipped.

Also for the test too, I added a component for the test which takes the result as a prop and passed the result in each td.

So in the state, I check if the test mode is active and display the test component, if not, it should display the flipper component which is named Hide.

On Sat, Mar 25, 2023 at 9:51 AM Medea @.***> wrote:

Hey dude this is amazing! The only problem is, with this solution, test mode function isn't working anymore. Also is there a way you can explain all the changes you have made?

— Reply to this email directly, view it on GitHub https://github.com/VulcanWM/discipulis-nextjs/pull/38#issuecomment-1483767365, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMFQ2ESDJHKDYHFLKNZJEOLW52W2XANCNFSM6AAAAAAWHJL6IY . You are receiving this because you authored the thread.Message ID: @.***>

Qudusayo commented 1 year ago

Hey dude this is amazing! The only problem is, with this solution, test mode function isn't working anymore. Also is there a way you can explain all the changes you have made?

All fixed now.

Didn't understand the logics at first and you didn't mention that, so I don't know about it until you mentioned, but it's now all fixed

VulcanWM commented 1 year ago

ayyy, the css is amazing! thanks for your help!