Open brianravi opened 9 months ago
Alright I'll review it this weekend and let you know if we need to meet Monday. Thank you!
Sounds good, thanks!
The only action I know that will be required on your part is a result of issue #1171 https://github.com/VulnerabilityHistoryProject/vulnerability-history/issues/1171
You will need to update the JSON files to place the keys into the project JSON files so that they pull in the shared questions where you want them.
From: Andy Meneely @.> Sent: Friday, October 27, 2023 3:35 PM To: VulnerabilityHistoryProject/vulnerability-history @.> Cc: Brian Robbins @.>; Author @.> Subject: Re: [VulnerabilityHistoryProject/vulnerability-history] Several Post-Launch Requests (PR #1184)
Alright I'll review it this weekend and let you know if we need to meet Monday. Thank you!
— Reply to this email directly, view it on GitHubhttps://github.com/VulnerabilityHistoryProject/vulnerability-history/pull/1184#issuecomment-1783411763, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A4BVYS566X6N5XHBKCB2KJ3YBQEHTAVCNFSM6AAAAAA6TE7JNWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBTGQYTCNZWGM. You are receiving this because you authored the thread.Message ID: @.***>
Summary
Addressed several post-launch requests
Have you...
Gemfile.lock
andyarn.lock
are't getting modified unintentionally?The above things are not required, but appreciated.