search

VundleVim / Vundle.vim

Vundle, the plug-in manager for Vim
http://github.com/VundleVim/Vundle.Vim
MIT License
23.91k stars 2.58k forks source link

Awesome installer has bugs #69

Closed jdevera closed 13 years ago

jdevera commented 13 years ago

I'm testing the nin branch and found this issue.

These are my bundles:

Bundle 'gmarik/vundle'
Bundle 'tomtom/tlib_vim'
Bundle 'MarcWeber/vim-addon-mw-utils'
Bundle "garbas/snipmate.vim"
Bundle 'honza/snipmate-snippets'
Bundle 'tpope/vim-repeat'
Bundle 'tpope/vim-surround'
Bundle 'Align'                  
Bundle 'camelcasemotion' 
Bundle 'Color-Scheme-Explorer'
Bundle 'Conque-Shell'         
Bundle 'davidoc/todo.txt-vim'
Bundle 'godlygeek/csapprox'
Bundle 'hallison/vim-markdown'        
Bundle 'jdevera/vim-stl-syntax'
Bundle 'majutsushi/tagbar'
Bundle 'pylint.vim'       
Bundle 'python.vim--Vasiliev'  
Bundle 'scrooloose/nerdcommenter'
Bundle 'scrooloose/nerdtree'
Bundle 'ShowMarks'          
Bundle 'TaskList.vim'            
Bundle 'tpope/vim-fugitive' 
Bundle 'xolox/vim-notes'
Bundle 'tomasr/molokai'

This is the Log:

Already up-to-date.^@
Cloning into /home/jdevera/.vim/bundle/tlib_vim...^@fatal: https://github.com/vim-scripts/tlib_vim.git/info/refs not found: did you run git update-server-info on the server?^@
Cloning into /home/jdevera/.vim/bundle/vim-addon-mw-utils...^@
Cloning into /home/jdevera/.vim/bundle/snipmate.vim...^@fatal: https://github.com/vim-scripts/snipmate.vim.git/info/refs not found: did you run git update-server-info on the server?^@
Cloning into /home/jdevera/.vim/bundle/snipmate-snippets...^@
Cloning into /home/jdevera/.vim/bundle/vim-repeat...^@fatal: https://github.com/vim-scripts/vim-repeat.git/info/refs not found: did you run git update-server-info on the server?^@
Cloning into /home/jdevera/.vim/bundle/vim-surround...^@fatal: https://github.com/vim-scripts/vim-surround.git/info/refs not found: did you run git update-server-info on the server?^@
Cloning into /home/jdevera/.vim/bundle/Align...^@
Cloning into /home/jdevera/.vim/bundle/camelcasemotion...^@
Cloning into /home/jdevera/.vim/bundle/Color-Scheme-Explorer...^@
Cloning into /home/jdevera/.vim/bundle/Conque-Shell...^@
Cloning into /home/jdevera/.vim/bundle/todo.txt-vim...^@fatal: https://github.com/vim-scripts/todo.txt-vim.git/info/refs not found: did you run git update-server-info on the server?^@
Cloning into /home/jdevera/.vim/bundle/csapprox...^@fatal: https://github.com/vim-scripts/csapprox.git/info/refs not found: did you run git update-server-info on the server?^@
Cloning into /home/jdevera/.vim/bundle/vim-markdown...^@fatal: https://github.com/vim-scripts/vim-markdown.git/info/refs not found: did you run git update-server-info on the server?^@
Cloning into /home/jdevera/.vim/bundle/vim-stl-syntax...^@fatal: https://github.com/vim-scripts/vim-stl-syntax.git/info/refs not found: did you run git update-server-info on the server?^@
Cloning into /home/jdevera/.vim/bundle/tagbar...^@fatal: https://github.com/vim-scripts/tagbar.git/info/refs not found: did you run git update-server-info on the server?^@
Cloning into /home/jdevera/.vim/bundle/pylint.vim...^@
Cloning into /home/jdevera/.vim/bundle/python.vim--Vasiliev...^@
Cloning into /home/jdevera/.vim/bundle/nerdcommenter...^@fatal: https://github.com/vim-scripts/nerdcommenter.git/info/refs not found: did you run git update-server-info on the server?^@
Cloning into /home/jdevera/.vim/bundle/nerdtree...^@fatal: https://github.com/vim-scripts/nerdtree.git/info/refs not found: did you run git update-server-info on the server?^@
Cloning into /home/jdevera/.vim/bundle/ShowMarks...^@
Cloning into /home/jdevera/.vim/bundle/TaskList.vim...^@
Cloning into /home/jdevera/.vim/bundle/vim-fugitive...^@fatal: https://github.com/vim-scripts/vim-fugitive.git/info/refs not found: did you run git update-server-info on the server?^@
Cloning into /home/jdevera/.vim/bundle/vim-notes...^@fatal: https://github.com/vim-scripts/vim-notes.git/info/refs not found: did you run git update-server-info on the server?^@
Cloning into /home/jdevera/.vim/bundle/molokai...^@

So it seems the user part of the repo is getting lost and the default vim-script is being used.

gmarik commented 13 years ago

@jdevera, that's a good catch! the ~/.vim-vundle/ dir is created when :BundleSearch is run, but i mistakenly assumed it's always there ) Will fix that

Taverius commented 13 years ago

@gmarik The prompt for :BundleClean is 'Continute?'

gmarik commented 13 years ago

@Taverius, hah, that's not correct! )

jdevera commented 13 years ago

Tested In windows, don´t know if it happens in Linux too:

When I run the installer, the show the log, then run the installer again, I get "E21: cannot make changes, 'modifiable' is off", and the buffer goes blank. if I run BundleInstall in that blank buffer then the installer runs again with no problems.

randymorris commented 13 years ago

@jdevera how are you calling up the log? I can't reproduce by pressing l then running BundleInstall again (linux).

Taverius commented 13 years ago

@rson :VundleLog after installer.

@jdevera I don't get that right now but I've seen it. Cannot reproduce right now, which is odd ...

@gmarik In that testing however I noticed if I run the installer, then the log, then the installer and then the log, vim complains that the logfile .tmp has been modified.

jdevera commented 13 years ago

@rson I am pressing l after the installer. It happens consistently in my box.

gmarik commented 13 years ago

hm, haven't been able to reproduce it yet...

jdevera commented 13 years ago

I was able to reproduce on my linux box as well, seems weird that only I am seeing this, I'm going to try to minimize my config and see what happens.

jdevera commented 13 years ago

I reduced my config to this:

set nocompatible
syntax on
filetype off
set rtp+=~/.vim/bundle/vundle/
call vundle#rc()
Bundle 'gmarik/vundle'
filetype plugin indent on

Clean - Log - Install

I ran a BundleClean!, then hit l to see the log, then ran BundleInstall and got this:

Error detected while processing function vundle#installer#clean..vundle#scripts#view:
line   11:
E21: Cannot make changes, 'modifiable' is off

I ran BundleInstall and got no error.

Install - Log - Install

I ran BundleInstall, then hit l to see the log, then ran BundleInstall again:

Error detected while processing function vundle#installer#new..vundle#scripts#view:
line   11:
E21: Cannot make changes, 'modifiable' is off

Similar error, but not the same exactly.

Install - close - Install

Another way I can repro this is by opening any file in vim, e.g., my vimrc. then run BundleInstall and close the installer window when it's done. Then try to run BundleInstall again and bang!, there it is again.

Error detected while processing function vundle#installer#new..vundle#scripts#view:
line   11:
E21: Cannot make changes, 'modifiable' is off

List - Log - List

I run BundleList, then hit l to see the log (empty, as expected) and then run BundleList again, I get this:

Error detected while processing function vundle#installer#list..vundle#scripts#view:
line   11:
E21: Cannot make changes, 'modifiable' is off

Notes

There are probably more cases, sometimes the errors disappear very quickly, I'm using the :messages command to see them.

Taverius commented 13 years ago

@jdevera Maybe the old buffers are not being deleted properly after use?

Does adding set hidden to your vimrc change the behaviour?

jdevera commented 13 years ago

@Taverius yes, with set hidden I get no errors. I did an ls and you are right, buffers are left there, I guess that is the problem. Are you guys all using set hidden? try turning it off maybe then you can repro this.

Taverius commented 13 years ago

@jdevera Confirmed for the Install - Close - Install case.

I find :h hidden to be fairly impenetrable in the implications, but I think the two cases here are either vundle uses bufhidden to hide single buffers, which works even when hidden is off, or, vundle cleans up its buffers on ... BufWinLeave, I believe is the appropriate event.

gmarik commented 13 years ago

@jdevera, thanks for awesome bugreport ) Will fix it

gmarik commented 13 years ago

Alright, pushed to master. @jdevera, just realized i've not fixed issue you submitted...8) Will push ASAP

gmarik commented 13 years ago

Also, pls upvote on reddit

Great job!! Thank you!!)

gmarik commented 13 years ago

Closing this as part of 0.9's milestone.

All pending issues moved to #80