search

Vungle / Windows-SDK

Other
21 stars 8 forks source link

Sample app update #10

Closed DavidKimVungle closed 7 years ago

DavidKimVungle commented 7 years ago

Temporarily put a working app ID until we can get something official in there like vungle_test. Added examples of event handlers. Added dignostic messages for CS version. Added more example for options.

DavidKimVungle commented 7 years ago

@sergeyksv Can you review the changes to public sample app and merge if everything looks good?

sergeyksv commented 7 years ago

@DavidKimVungle You didn't change appid in VB and DirectX sample. https://github.com/Vungle/Windows-SDK/blob/sample-app-update/Windows%20Universal%20Samples/DirectX_XAML_sample/DirectXPage.xaml.cpp#L37 and https://github.com/Vungle/Windows-SDK/blob/sample-app-update/Windows%20Universal%20Samples/VB_sample/MainPage.xaml.vb#L15.

Besides that looks good for me.

DavidKimVungle commented 7 years ago

Hi Sergey,

I wasn't able to get to VB and DirectX and also I never had a support request for those. I will get to them in the near future once I have more bandwidth. I wanted to get a working build out with more examples for C# and C++, which is used most by publishers.

Thanks, David

On Fri, Apr 21, 2017 at 10:06 AM, Sergey Korotkov notifications@github.com wrote:

@DavidKimVungle https://github.com/DavidKimVungle You didn't change appid in VB and DirectX sample. https://github.com/Vungle/ Windows-SDK/blob/sample-app-update/Windows%20Universal% 20Samples/DirectX_XAML_sample/DirectXPage.xaml.cpp#L37 and https://github.com/Vungle/Windows-SDK/blob/sample-app- update/Windows%20Universal%20Samples/VB_sample/MainPage.xaml.vb#L15.

Besides that looks good for me.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Vungle/Windows-SDK/pull/10#issuecomment-296248316, or mute the thread https://github.com/notifications/unsubscribe-auth/AUJxqpNj5YRMXxIO8l89qx77v6yigurmks5ryOIlgaJpZM4NCYYd .

DavidKimVungle commented 7 years ago

I have updated all test app ID to Test_Windows, including VB and DirectX sample.