Vurv78 / WebAudio

A safe, efficient and powerful replacement for Streamcore that adds playing & manipulating URL streams through IGmodAudioChannel/BASS
https://steamcommunity.com/sharedfiles/filedetails/?id=2466875474
MIT License
18 stars 3 forks source link

Last update (#12) causes streams to be too quiet & range does not work #13

Closed ghost closed 3 years ago

ghost commented 3 years ago

The last update (#12) causes streams to have very a low volume (the volume does change when webaudio:volume() is used, but the stream is very quiet), and the audio can be heard regardless of distance from E2 to player. Setting the range seems to make no difference to this.

Vurv78 commented 3 years ago

I was hoping this wouldn't be the case but I couldn't find any documentation as to why Set3DFadeDistance is so weird or how to use it properly.

It was working fine for me, maybe I'll have to make a modular think hook system for the receiver which will be annoying.. but worth it for future editions and so we don't have constant timers running that do nothing like most addons do

ghost commented 3 years ago

I noticed that in the code, the values seem to be very strange for the set3DFadeDistance function bass:Set3DFadeDistance(self.radius, 1000000000) The radius seems to be set to the wrong value? This would modify the minimum radius, not the maximum radius, surely?

Vurv78 commented 3 years ago

Yes, doing the opposite (which would seem correct) yielded the same results as you are having for me. I heard the sound across the map

ghost commented 3 years ago

Looks like you're right; the values are reversed: if I set the minimum to 1 and maximum to 2000, the sound fades in after I get a (very) far distance away from the E2 chip.

Vurv78 commented 3 years ago

Very weird so yeah we'll just manually set the volume like streamcore does. Either way we needed to do this in order to add #11