search

Vurv78 / WebAudio

A safe, efficient and powerful replacement for Streamcore that adds playing & manipulating URL streams through IGmodAudioChannel/BASS
https://steamcommunity.com/sharedfiles/filedetails/?id=2466875474
MIT License
18 stars 3 forks source link

Add api.onedrive.com to webaudio default whitelist #72

Closed yingKatsu closed 1 month ago

yingKatsu commented 1 month ago

Another way to have direct links to onedrive content that pac users often use.

Example link: https://api.onedrive.com/v1.0/shares/u!aHR0cHM6Ly8xZHJ2Lm1zL3UvcyFBcmFSdWJSdXY0SlM5azRMN3F4T1R6YkNYRkd0P2U9a093U3Az/root/content

Pac3 documentation containing a convenient converter for onedrive indirect links to api.onedrive.com direct links: https://wiki.pac3.info/tutorial/hosting

yogwoggf commented 1 month ago

Courtesy note: @Vurv78 is no longer actively maintaining webaudio so you may want to ping/ask someone with write access to the repository for this PR to get merged

yingKatsu commented 1 month ago

Courtesy note: @Vurv78 is no longer actively maintaining webaudio so you may want to ping/ask someone with write access to the repository for this PR to get merged

Thank you for your consideration; I was aware that he had left Garry's Mod but while doing this same pr to Starfall and looking into webaudio I noticed that they had recently commented a day ago on a wiremod pr so I thought that maybe there was a chance. Would you happen to know anyone with write access that I could ping, or is webaudio now actively maintained by someone else under a different repo?

yogwoggf commented 1 month ago

Courtesy note: @Vurv78 is no longer actively maintaining webaudio so you may want to ping/ask someone with write access to the repository for this PR to get merged

Thank you for your consideration; I was aware that he had left Garry's Mod but while doing this same pr to Starfall and looking into webaudio I noticed that they had recently commented a day ago on a wiremod pr so I thought that maybe there was a chance. Would you happen to know anyone with write access that I could ping, or is webaudio now actively maintained by someone else under a different repo?

Makes sense, I just saw the review comment you were talking about. Anyways, I'm not totally sure, but potentially @StyledStrike could have write access?

Vurv78 commented 1 month ago

I will not do anything that involves me ingame or takes a ton of time, but if people want to make PRs to my repos I will briefly review and merge if it's fine.

StyledStrike commented 1 month ago

Makes sense, I just saw the review comment you were talking about. Anyways, I'm not totally sure, but potentially @StyledStrike could have write access?

oh I did only two small pull requests here, I'm not a maintainer