search

VyacheslavRadyuk / sf-senla-courses

0 stars 0 forks source link

2.6.2 Bad implementation #79

Closed NikitaErmakSenla closed 3 years ago

NikitaErmakSenla commented 3 years ago

https://github.com/VyacheslavRadyuk/sf-senla-courses/blob/2c8abbad38ee23c5936dd8445aabf1c929daecda/lecture_2.6/TouristRestService.cls#L46

NikitaErmakSenla commented 3 years ago

  1. getTouristsValidationTrue - bad naming. E.g. - handleValidationError

  2. If Age wasn't filled - it's not validation error. This logic i ssupposed to be in getTourists() method

VyacheslavRadyuk commented 3 years ago

done