search

Vydia / react-native-background-upload

Upload files in your React Native app even while it's backgrounded. Supports Android and iOS, including camera roll assets.
MIT License
735 stars 336 forks source link

Consider using NativeEventEmitter instead of DeviceEventEmitter #153

Open cristianoccazinsp opened 5 years ago

cristianoccazinsp commented 5 years ago

Any reason DeviceEventEmitter is being used? I've been testing using the recommended NativeEventEmitter and it seems to work fine. https://facebook.github.io/react-native/docs/native-modules-ios#sending-events-to-javascript

Might also want to consider the following optimization from the docs: https://facebook.github.io/react-native/docs/native-modules-ios#optimizing-for-zero-listeners

pribeh commented 4 years ago

bump