Vydia / react-native-background-upload

Upload files in your React Native app even while it's backgrounded. Supports Android and iOS, including camera roll assets.
MIT License
735 stars 335 forks source link

Merges #133 (Feat android broadcastreceiver) fixes bugs and updates README #163

Closed APZelos closed 5 years ago

APZelos commented 5 years ago

Merges pull request #133, Fixes error when trying to upload without showing a notification on Android versions >= 8.0 Oreo and Updates readme linking section for React Native 0.60.

Also closes #156

quarryman commented 5 years ago

@APZelos hi. Can you please confirm that as of Android >= 8.0 Oreo we are not allowed to disable notifications due to Google policy for background services?

If so, this becomes very confusing as we receive notification(sound) on each uplaod progress percent, (might be 10+ times per upload)

APZelos commented 5 years ago

Seems like the wiki link I provided in the original issue no longer exists. You can see details here and here.

You should only use a foreground service when your app needs to perform a task that is noticeable by the user even when they're not directly interacting with the app. For this reason, foreground services must show a status bar notification with a priority of PRIORITY_LOW or higher, which helps ensure that the user is aware of what your app is doing.

xHeinrich commented 5 years ago

Been using this in a prod application for a month or so with no issues.

github-actions[bot] commented 4 years ago

:tada: This PR is included in version 5.2.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: