Adding iOS timeout props

Vydia / react-native-background-upload

Upload files in your React Native app even while it's backgrounded. Supports Android and iOS, including camera roll assets.

MIT License

726 stars 332 forks source link

Adding iOS timeout props #175

Closed reime005 closed 3 years ago

reime005 commented 4 years ago

This PR adds the possibility to change the request timeouts for iOS.

BarakGong commented 4 years ago

We should expose those timeouts, but they should be handled on the NSURLSessionConfiguration level (when creating the session), and not the NSURLRequest. Also, timeoutIntervalForResource is not the same as timeoutIntervalForRequest.

reime005 commented 4 years ago

I totally agree with the code. I found out some time ago, but forgot that I have an open PR here...

@BarakGong does that look better to you?

Where did I say that these timeouts are the same?