Fix untracable crashes when URL is not parsable

Vydia / react-native-background-upload

Upload files in your React Native app even while it's backgrounded. Supports Android and iOS, including camera roll assets.

MIT License

735 stars 335 forks source link

Fix untracable crashes when URL is not parsable #183

Closed Palid closed 4 years ago

Palid commented 4 years ago

Due to NSURL checking compliance with RFC 2396 while parsing the url, sometimes when the URL is not compilant with the RFC it is considered nil and code throws this error. The problem is that this error is not caught anywhere, therefore crashing with a very unhelpful stack trace, as seen here: https://github.com/Vydia/react-native-background-upload/issues/121

github-actions[bot] commented 4 years ago

:tada: This PR is included in version 5.2.1 :tada:

The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket: