search

Vydia / react-native-background-upload

Upload files in your React Native app even while it's backgrounded. Supports Android and iOS, including camera roll assets.
MIT License
723 stars 330 forks source link

Use android version from root project. Update kotlin to 1.4.0 #216

Closed TikiTDO closed 3 years ago

TikiTDO commented 4 years ago

Summary

This PR addresses 2 issues:

  1. Android build was not respecting the SDK config of the root project, causing really weird build errors if the version I had configured was not 29. This PR adds code to use the target/compile version from the project using the lib.

  2. The version of Kotlin that was configured did not work with my environment. This PR bumps the version to 1.4.0, and fixes a compile time error in android.

Test Plan

Majority of changes are to the build environment. Only code change is to fix a build-time "smart cast is impossible" error.

To test build an app that uses this library. Perform an upload.

Compatibility

OS Implemented
iOS Not Affected
Android ✅

Checklist

reime005 commented 3 years ago

@TikiTDO very cool! we missed that before, thanks

github-actions[bot] commented 3 years ago

:tada: This PR is included in version 6.2.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: