Vydia / react-native-background-upload

Upload files in your React Native app even while it's backgrounded. Supports Android and iOS, including camera roll assets.
MIT License
720 stars 325 forks source link

Support for SDK 34 #347

Open anindya2791 opened 3 months ago

anindya2791 commented 3 months ago

This should solve https://github.com/Vydia/react-native-background-upload/issues/343 Thanks @sandeep14

Summary

Test Plan

What's required for testing (prerequisites)?

What are the steps to reproduce (after prerequisites)?

Compatibility

OS Implemented
iOS ✅❌
Android ✅❌

Checklist

mtshv commented 6 days ago

hey @anindya2791 I've implemented your changes and it indeed builds and works as expected. Thanks for your work (cc @sandeep14)

However, I have issues with uploading my APK to the google play store due to

"message": "You must let us know whether your app uses any Foreground Service permissions.",
"status": "PERMISSION_DENIED"

I think it might be related to the net.gotev:uploadservice-okhttp version bump: https://github.com/Vydia/react-native-background-upload/pull/347/files#diff-197b190e4a3512994d2cebed8aff5479ff88e136b8cc7a4b148ec9c3945bd65aR67

See this issue: https://github.com/gotev/android-upload-service/issues/660


If you guys have the same issue, or any ideas, how to solve it, please let me know.