Program crashes after an Edit action

Vykook / acme-sac

Automatically exported from code.google.com/p/acme-sac

Other

0 stars 0 forks source link

Program crashes after an Edit action #7

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago

What steps will reproduce the problem?
1. Start Win
2. Execute Edit 1,$d
3. Press enter

What version of the product are you using? On what operating system?
Version 0.21 on OS X

Original issue reported on code.google.com by ja...@basen.net on 22 Oct 2007 at 6:20

GoogleCodeExporter commented 8 years ago

Confirmed under version 0.9.9 for Linux.

--underspecified

Original comment by underspe...@gmail.com on 22 Oct 2007 at 6:23

GoogleCodeExporter commented 8 years ago

This bug was fixed in Plan 9 on 18th February 2003:
http://9fans.net/archive/2003/02/183

I copied those changes to acme-sac and the program no longer crashes.
The attached patch is untested otherwise.

Original comment by arvin...@gmail.com on 27 Oct 2007 at 6:03

Attachments:

edit-crash.patch

GoogleCodeExporter commented 8 years ago

Thanks! I confirmed the crash, and applied the patch to my tree. Will see what
happens. But this may well explain other crashes I've seen with Edit. Edit is 
the
most frequent cause of acme crashes for me.

Original comment by caerw...@gmail.com on 28 Oct 2007 at 12:00

Changed state: Fixed

GoogleCodeExporter commented 8 years ago

The fix causes some other warnings to appear such as when doing 
Edit ,x/<cr>/d
causes the following warning where it never occurred before
elogapply: can't happen 923 923 892

Original comment by caerw...@gmail.com on 31 Oct 2007 at 1:20

Changed state: Accepted

GoogleCodeExporter commented 8 years ago

Thanks Caerwyn.  I have reworked and tested the patch,
copying relevant changes from the latest Plan 9 source
(instead of from /n/sourcesdump/2003, as I did earlier).

"Edit X/README/D" doesn't always work.  This issue exists in
acme-0.9.9 as well.  I haven't looked into this yet.

While working on the patch, I created a Mercurial repository
of /sys/src/cmd/acme history from sourcesdump (my network
access to sources was very slow).  It is available at:
http://mordor.tip9ug.jp/who/art/acme9.tar.gz

I run "hg serve" and access the repository at
http://localhost:8000/?style=gitweb to view
changesets and annotated source.

Original comment by arvin...@gmail.com on 6 Nov 2007 at 3:42

Changed state: Fixed

Attachments:

edit-crash.take2

GoogleCodeExporter commented 8 years ago

Thanks Arvindh. After the problem I had I compared the code with p9p acme and 
made it
match that. That solved it for me. And comparing it with your second patch I 
think we
were very close. I've applied your changes.

Original comment by caerw...@gmail.com on 7 Nov 2007 at 3:02