search

Vyrastas / bbcode_guide_template

BBCode Guide Template for playstationtrophies.org and xboxachievements.com
http://www.vyrastas.com/guide_template.htm
MIT License
1 stars 2 forks source link

Dynamic page numbering for loop #5

Closed slammajamma28 closed 4 years ago

slammajamma28 commented 4 years ago

Hopefully, the changes I made for dynamic page numbering work!

Vyrastas commented 4 years ago

Sorry for the delay in looking at this... I'll verify that it works on my end tomorrow.

slammajamma28 commented 4 years ago

I also re-did for formatting, a lot of the indentation did not line up and it was driving me crazy. There were also a lot of instances of blank spaces at the end of the lines which I fixed.

Vyrastas commented 4 years ago

Thanks for reformatting and cleaning up đź‘Ť

So this works fine as far as I can tell, however — it slows down the game list page quite a bit. Selecting a letter that previously took 6 seconds to return now takes 10 seconds. I can push it to my site but it might be good to add a note that some letters may take a while to return. Are you okay with that?

I'd also like to add a "processing" animation or something so people knowing it's working, but that can be done separately.

slammajamma28 commented 4 years ago

So this works fine as far as I can tell, however — it slows down the game list page quite a bit. Selecting a letter that previously took 6 seconds to return now takes 10 seconds. I can push it to my site but it might be good to add a note that some letters may take a while to return. Are you okay with that?

I was just testing it out myself using my phone's stopwatch. I deployed both my code and your master code locally.

For 'T', the master code took about 10 seconds and my code took about 11.5 seconds. For 'S', the master code took about 10.5 seconds and my code took 12.5 seconds.

For some reason, the live site seems to pause before displaying anything while the local version appears to slowly display the text but the time for it to load is in line with the local master code times.

But yeah, I don't think the increase in wait time is too alarming.

I'd also like to add a "processing" animation or something so people knowing it's working, but that can be done separately.

I agree, this would be a nice addition! In the meantime, a line of text could be added to ps3t_fr_include_alpha.php to state that some letters make take longer than others to display. I can also make a note on PST about the slight increase in wait time.

Vyrastas commented 4 years ago

Yeah, my site is a bit slower than running locally. Not sure what the difference in progressive loading might be due to... PHP version? Web server? I don't know enough about how that works tbh.

I'll add a note about slow load times, then push the update to my website.

slammajamma28 commented 4 years ago

Righteous! Believe it or not, this was my first legitimate pull request with actual review. It was a pleasure!

A few members at PST have requested an addition to the guide template which I’ll be working on... shouldn’t be as extravagant as dynamic page numbering... but we’ll see :)