search

Vysci / LFG-Bulletin-Board

Dungeon Request chat filtering
MIT License
15 stars 64 forks source link

Fixing CustomFilters errors #259

Closed Vysci closed 4 months ago

Vysci commented 4 months ago

Fixing lua errors that occur in the case CustomFilters hasn't been initialized.

juemrami commented 4 months ago

Good catch. I had handled this but i removed it on accident with #255 /facepalm

See the blame here

It was meant to be checked in the InitializeCustomFilters function. I think its better to keep any saved variable creation/manipulation related to custom filters in the same CustomCategories file. Thoughts @Vysci

Vysci commented 4 months ago

I think DB creation should either all be created in one function or in the init function of the corresponding file that goes with the DB. Basically I'm okay either way but it needs to be consistent. I just threw it here because I know thats where I do most of the DB creation and I had to hurry up to a meeting

juemrami commented 4 months ago

Alright. I opened a PR with the suggested changes, approve if you agree.

Also, IMO "Rebase + Merge" makes for a much nicer commit history when merging a branch with independent or single commits.