Vysci / LFG-Bulletin-Board

Dungeon Request chat filtering
MIT License
15 stars 63 forks source link

Lua error #281

Closed waytoomuchgaming closed 2 months ago

waytoomuchgaming commented 2 months ago

Describe the bug 1x ...rfaceLFGBulletinBoard/GroupBulletinBoard.lua:147: attempt to index field '?' (a nil value) [string "@LFGBulletinBoard/GroupBulletinBoard.lua"]:147: in function FilterDungeon' [string "@LFGBulletinBoard/RequestList.lua"]:867: in functionParseMessage' [string "@LFGBulletinBoard/GroupBulletinBoard.lua"]:845: in function `?' [string "@LFGBulletinBoard/LibGPIToolBox.lua"]:119: in function <LFGBulletinBoard/LibGPIToolBox.lua:116>

Locals: dungeon = "DFC" isHeroic = false isRaid = false (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (*temporary) = "attempt to index field '?' (a nil value)" GBB =

{ GetLfgList = defined @LFGBulletinBoard/LfgToolList.lua:133 CreateTagList = defined @LFGBulletinBoard/GroupBulletinBoard.lua:392 GetDungeonNames = defined @LFGBulletinBoard/Dungeons.lua:12 ClearNeeded = false InitGroupList = defined @LFGBulletinBoard/GroupList.Lua:177 TBCMAXDUNGEON = 32 LfgRequestHideTooltip = defined @LFGBulletinBoard/LfgToolList.lua:727 tagList =
{ } GetSortedDungeonKeys = defined @LFGBulletinBoard/dungeons/classic.lua:273 suffixTags =
{ } LevelRange = defined @LFGBulletinBoard/GroupBulletinBoard.lua:129 ParseMessage = defined @LFGBulletinBoard/RequestList.lua:774 LFG_Successfulljoined = true ClearTimer = 1752399386 UpdateLfgToolNoSearch = defined @LFGBulletinBoard/LfgToolList.lua:229 NotifySound = 1210 JoinLFG = defined @LFGBulletinBoard/GroupBulletinBoard.lua:195 searchTagsLoc =
{ } FoldAllDungeon = defined @LFGBulletinBoard/RequestList.lua:941 ClickFrame = defined @LFGBulletinBoard/RequestList.lua:981 CreateChatFrame = defined @LFGBulletinBoard/Chat.lua:3 Initalized = true BtnClose = defined @LFGBulletinBoard/GroupBulletinBoard.lua:328 MAXCOMPACTWIDTH = 350 OnLoad = defined @LFGBulletinBoard/GroupBulletinBoard.lua:871 WOTLKDUNGEONSTART = 33 dungeonSecondTags =
{ } rawClassicDungeonInfo =
{ } Version = "3.33" TAGBAD = "---" GetCustomFilterKeys = defined @LFGBulletinBoard/CustomCategories.lua:148 GetDungeons = defined @LFGBulletinBoard/RequestList.lua:584 GetDungeonSort = defined @LFGBulletinBoard/Dungeons.lua:729 TBCDUNGEONSTART = 33 heroicTagsLoc =
{ } LocalizationInit = defined @LFGBulletinBoard/Localization.lua:825 Popup_Minimap = defined @LFGBulletinBoard/GroupBulletinBoard.lua:476 ClickDungeon = defined @LFGBulletinBoard/RequestList.lua:988 Tool =
{ } HeroicKeywords =
{ } RequestShowTooltip = defined @LFGBulletinBoard/RequestList.lua:1037 OptionsInit = defined @LFGBulletinBoard/Options.lua:280 AllowInInstance = defined @LFGBulletinBoard/GroupBulletinBoard.lua:50 MSGPREFIX = "LFG Bulletin Board: " UpdateLfgTool = defined @LFGBulletinBoard/LfgToolList.lua:207 OptionsUpdate = defined @LFGBulletinBoard/Options.lua:113 Announce = defined @LFGBulletinBoard/Chat.lua:140 LFG_UPDATETIME = 10 LfgUpdateList = defined @LFGBulletinBoard/LfgToolList.lua:489 BtnSelectChannel = defined @LFGBulletinBoard/GroupBulletinBoard.lua:264 GetCustomFilterNames = defined @LFGBulletinBoard/CustomCategories.lua:198 LfgRequestShowTooltip = defined @LFGBulletinBoard/LfgToolList.lua:678 GetRaids = defined @LFGBulletinBoard/Dungeons.lua:702 L =
{ } ElapsedSinceListUpdate = 0.080000 Init = defined @LFGBulletinBoard/GroupBulletinBoard.lua:503 ENDINGDUNGEONEND = 39 SyncCustomFilterTags = defined @LFGBulletinBoard/CustomCategories.lua:167 RequestList =
{ } ShouldReset = false LFG_Timer = 1720860707 RaidList =
{ } locales =
{ } TBCDUNGE

Desktop (please complete the following information):

waytoomuchgaming commented 2 months ago

Another one : 2x LFGBulletinBoard/RequestList.lua:807: attempt to perform arithmetic on field 'last' (a nil value) [string "@LFGBulletinBoard/RequestList.lua"]:807: in function ParseMessage' [string "@LFGBulletinBoard/GroupBulletinBoard.lua"]:845: in function?' [string "@LFGBulletinBoard/LibGPIToolBox.lua"]:119: in function <LFGBulletinBoard/LibGPIToolBox.lua:116>

Locals: msg = "C#RE##any high level tailor on ?" sender = "Meddl-ZandalarTribe" guid = "Player-5232-0291C725" channel = "topSekrtiChan" appendTime = 0.940000 requestTime = 1720861100.940000 doUpdate = false locClass = "Warlock" engClass = "WARLOCK" locRace = "Gnome" engRace = "Gnome" Gender = 2 gName = "Meddl" gRealm = "" name = "Meddl" server = "ZandalarTribe" updated = false (for generator) = defined =[C]:-1 (for state) =

{ 1 =
{ } 2 =
{ } 3 =
{ } 4 =
{ } 5 =
{ } 6 =
{ } 7 =
{ } 8 =
{ } 9 =
{ } 10 =
{ } 11 =
{ } 12 =
{ } } (for control) = 9 ir = 9 req =
{ dungeon = "DFC" IsPastPlayer = false guid = "Player-5232-0291C725" start = 1720861001.464000 class = "WARLOCK" IsFriend = false IsGuildMember = false } (temporary) = nil (temporary) = 10 (temporary) = "table" (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (*temporary) = "attempt to perform arithmetic on field 'last' (a nil value)" GBB =
{ GetLfgList = defined @LFGBulletinBoard/LfgToolList.lua:133 CreateTagList = defined @LFGBulletinBoard/GroupBulletinBoard.lua:392 GetDungeonNames = defined @LFGBulletinBoard/Dungeons.lua:12 ClearNeeded = false InitGroupList = defined @LFGBulletinBoard/GroupList.Lua:177 TBCMAXDUNGEON = 32 LfgRequestHideTooltip = defined @LFGBulletinBoard/LfgToolList.lua:727 tagList =
{ } GetSortedDungeonKeys = defined @LFGBulletinBoard/dungeons/classic.lua:273 suffixTags =
{ } LevelRange = defined @LFGBulletinBoard/GroupBulletinBoard.lua:129 ParseMessage = defined @LFGBulletinBoard/RequestList.lua:774 LFG_Successfulljoined = true ClearTimer = 1752399386 UpdateLfgToolNoSearch = defined @LFGBulletinBoard/LfgToolList.lua:229 NotifySound = 1210 JoinLFG = defined @LFGBulletinBoard/GroupBulletinBoard.lua:195 searchTagsLoc =
{ } FoldAllDungeon = defined @LFGBulletinBoard/RequestList.lua:941 ClickFrame = defined @LFGBulletinBoard/RequestList.lua:981 CreateChatFrame = defined @LFGBulletinBoard/Chat.lua:3 Initalized = true BtnClose = defined @LFGBulletinBoard/GroupBulletinBoard.lua:328 MAXCOMPACTWIDTH = 350 OnLoad = defined @LFGBulletinBoard/GroupBulletinBoard.lua:871 WOTLKDUNGEONSTART = 33 dungeonSecondTags =
{ } rawClassicDungeonInfo =
{ } Version = "3.33" TAGBAD = "---" GetCustomFilterKeys = defined @LFGBulletinBoard/CustomCategories.lua:148 GetDungeons = defined @LFGBulletinBoard/RequestList.lua:584 GetDungeonSort = defined @LFGBulletinBoard/Dungeons.lua:729 TBCDUNGEONSTART = 33 heroicTagsLoc =
{ } LocalizationInit = defined @LFGBulletinBoard/Localization.lua:825 Popup_Minimap = defined @LFGBulletinBoard/GroupBulletinBoard.lua:476 ClickDungeon = defined @LFGBulletinBoard/RequestList.lua:988 Tool =
{ } HeroicKeywords =
{ } RequestShowTooltip = defined @LFGBulletinBoard/RequestList.lua:1037 OptionsInit = defined @LFGBulletinBoard/Options.lua:280 AllowInInstance = defined @LFGBulletinBoard/GroupBulletinBoard.lua:50 MSGPREFIX = "LFG Bulletin Board: " UpdateLfgTool = defined @LFGBulletinBoard/LfgToolList.lua:207 OptionsUpdate = defined @

Both errors appened while doing nothing (OOC, not moving or interacting).

waytoomuchgaming commented 2 months ago

I think it conflict with another addon (i have a lot of lua errors, not just the 2 i posted). I disabled the search on the chanel the other addon set up, and it seems ok.

Vysci commented 2 months ago

@waytoomuchgaming what game version awere you playing

Belden1 commented 2 months ago

image

image

Same problem, classic era (1.15.3.55563), v3.34

Didn't happend for a while, but suddenly started getting alot of LUA ui error spam in chat...

Vysci commented 2 months ago

@Belden1 @waytoomuchgaming I'll look closer at it in next day or two. Not a whole lot of sleep past couple days.

In the mean time you can run the following command in chat. /run GroupBulletinBoard_Addon.DBChar["FilterDungeonDFC"] = false you can just copy and paste in chat

waytoomuchgaming commented 2 months ago

/run GroupBulletinBoard_Addon.DBChar["FilterDungeonDFC"] = false

The command don't do anything. WoW is 1.15.3(55563). But disabling a certain chanel (the one created by addon Greenwall) in LFG solve the problem. No more bug.

juemrami commented 2 months ago

@Vysci, Ive force enabled FilterDungeonDFC to true on my client, but im not able to reproduce @Belden1's issue. Tested on both era/hc realms (v3.34) image

If you're experience the issue still after running /run GroupBulletinBoard_Addon.DBChar["FilterDungeonDFC"] = false, then it would help if you could copypaste the full text from BugGrabber @Belden1. Ty for reporting.

juemrami commented 2 months ago

Got the error on cataclysm

1599x ...rfaceLFGBulletinBoard/GroupBulletinBoard.lua:147: attempt to index field '?' (a nil value)
[string "@LFGBulletinBoard/GroupBulletinBoard.lua"]:147: in function `FilterDungeon'
[string "@LFGBulletinBoard/RequestList.lua"]:867: in function `ParseMessage'
[string "@LFGBulletinBoard/GroupBulletinBoard.lua"]:852: in function `?'
[string "@LFGBulletinBoard/LibGPIToolBox.lua"]:119: in function <LFGBulletinBoard/LibGPIToolBox.lua:116>

Locals:
dungeon = "DFC"
isHeroic = false
isRaid = false
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to index field '?' (a nil value)"
GBB = <table> {
 GetLfgList = <function> defined @LFGBulletinBoard/LfgToolList.lua:133
 CreateTagList = <function> defined @LFGBulletinBoard/GroupBulletinBoard.lua:392
 GetDungeonNames = <function> defined @LFGBulletinBoard/Dungeons.lua:12
 ClearNeeded = false
 InitGroupList = <function> defined @LFGBulletinBoard/GroupList.Lua:177
 TBCMAXDUNGEON = 51
 LfgRequestHideTooltip = <function> defined @LFGBulletinBoard/LfgToolList.lua:727
 tagList = <table> {
 }
 GetSortedDungeonKeys = <function> defined @LFGBulletinBoard/dungeons/cata.lua:497
 suffixTags = <table> {
 }
 LevelRange = <function> defined @LFGBulletinBoard/GroupBulletinBoard.lua:129
 ParseMessage = <function> defined @LFGBulletinBoard/RequestList.lua:774
 LFG_Successfulljoined = true
 ClearTimer = 1721081727.220000
 UpdateLfgToolNoSearch = <function> defined @LFGBulletinBoard/LfgToolList.lua:229
 NotifySound = 1210
 JoinLFG = <function> defined @LFGBulletinBoard/GroupBulletinBoard.lua:195
 searchTagsLoc = <table> {
 }
 FoldAllDungeon = <function> defined @LFGBulletinBoard/RequestList.lua:941
 ClickFrame = <function> defined @LFGBulletinBoard/RequestList.lua:981
 CreateChatFrame = <function> defined @LFGBulletinBoard/Chat.lua:3
 Initalized = true
 BtnClose = <function> defined @LFGBulletinBoard/GroupBulletinBoard.lua:328
 ScrollGroupList = <function> defined @LFGBulletinBoard/GroupList.Lua:253
 OnLoad = <function> defined @LFGBulletinBoard/GroupBulletinBoard.lua:878
 WOTLKDUNGEONSTART = 52
 dungeonSecondTags = <table> {
 }
 Version = "3.33"
 TAGBAD = "---"
 GetCustomFilterKeys = <function> defined @LFGBulletinBoard/CustomCategories.lua:158
 GetDungeons = <function> defined @LFGBulletinBoard/RequestList.lua:584
 GetDungeonSort = <function> defined @LFGBulletinBoard/Dungeons.lua:729
 TBCDUNGEONSTART = 28
 heroicTagsLoc = <table> {
 }
 LocalizationInit = <function> defined @LFGBulletinBoard/Localization.lua:825
 Popup_Minimap = <function> defined @LFGBulletinBoard/GroupBulletinBoard.lua:476
 ClickDungeon = <function> defined @LFGBulletinBoard/RequestList.lua:988
 Tool = <table> {
 }
 HeroicKeywords = <table> {
 }
 RequestShowTooltip = <function> defined @LFGBulletinBoard/RequestList.lua:1037
 OptionsInit = <function> defined @LFGBulletinBoard/Options.lua:280
 AllowInInstance = <function> defined @LFGBulletinBoard/GroupBulletinBoard.lua:50
 MSGPREFIX = "LFG Bulletin Board: "
 UpdateLfgTool = <function> defined @LFGBulletinBoard/LfgToolList.lua:207
 OptionsUpdate = <function> defined @LFGBulletinBoard/Options.lua:113
 Announce = <function> defined @LFGBulletinBoard/Chat.lua:140
 LFG_UPDATETIME = 10
 LfgUpdateList = <function> defined @LFGBulletinBoard/LfgToolList.lua:489
 BtnSelectChannel = <function> defined @LFGBulletinBoard/GroupBulletinBoard.lua:264
 GetCustomFilterNames = <function> defined @LFGBulletinBoard/CustomCategories.lua:208
 LfgRequestShowTooltip = <function> defined @LFGBulletinBoard/LfgToolList.lua:678
 GetRaids = <function> defined @LFGBulletinBoard/Dungeons.lua:702
 L = <table> {
 }
 ElapsedSinceListUpdate = 0.334000
 Init = <function> defined @LFGBulletinBoard/GroupBulletinBoard.lua:503
 ENDINGDUNGEONEND = 110
 SyncCustomFilterTags = <function> defined @LFGBulletinBoard/CustomCategories.lua:177
 RequestList = <table> {
 }
 ShouldReset = false
 cataRawDungeonInfo = <table> {
 }
 RaidList =
juemrami commented 2 months ago

I found the source of the issue i think @Vysci.

Whats the reason for including, DFC, in this conditional block of GBB.GetDungeons()?

if dungeons["DEADMINES"] 
  and not dungeons["DMW"] 
  and not dungeons["DME"] 
  and not dungeons["DME"] 
  and name ~= nil 
then
  if nameLevel>0 and nameLevel<40 then
    dungeons["DM"]=true
    dungeons["DM2"]=false
    dungeons["DFC"]=false
  else
    dungeons["DM"]=false
    dungeons["DM2"]=true
    dungeons["DFC"]=true -- this line is likely causing the error even with the FilterDungeonDFC set `false`
  end
end

From when i looked into this code last, these edge cases were added by the original author (in ~v1.80), when they were trying to have messages with "dm" in it propperly identified as either for Dire Maul or Deadmines.