search

Vysci / LFG-Bulletin-Board

Dungeon Request chat filtering
MIT License
15 stars 64 forks source link

revert: re-add "migrate `DropDownMenu` to utilize `SavedVarRegistry`" #283

Closed juemrami closed 4 months ago

juemrami commented 4 months ago

This is a re-implementation of #275, following @Vysci's reverts in #278 & #279

Id like some more info surrounding the issues you encountered that lead to the reversion, so i know at what point to debug. I've gone and checked the state of the addon in commits in #275, #276, #277 on SoD trying to find an error but no luck.

I havent changed any code from these commits that i'm testing vs the original PR commits (rest of PR's will be submitted after this one), so any errors you encountered would still be in here, thats why i ask.

juemrami commented 4 months ago

Lets wait to do these re-reversions until after these PR's and related issues have been resolved

Vysci commented 4 months ago

Let me see if I can reproduce it again. I should have captured the error.

juemrami commented 4 months ago

You said you were on SoD so i've been spending some time on there with these changes and havent gotten any errors. So they may have been related to a previous in-compatibility with the DFC changes that may have been fixed with the recent changes.

@Vysci. I'm going to re-merge these changes to get an alpha out to CF and see if i get any error reports

Vysci commented 4 months ago

Can’t remember if it was in SoD or if that was when I tried to make sure that my changes didn’t break Cata.

I’m out of town until next week so can’t look

juemrami commented 4 months ago

Np. ill test it and get the changes out then. 👍