search

Vysci / LFG-Bulletin-Board

Dungeon Request chat filtering
MIT License
15 stars 64 forks source link

WoW Cata - Bastion of Twilight Filter Broken #299

Closed knobs-afk closed 2 weeks ago

knobs-afk commented 1 month ago

Describe the bug Messages with "bot" do not get filtered under the "Bastion of Twilight" group. Enabling "Botanica" filter will put messages with "bot" under that group. With "Botanica" disabled messages containing "bot" do not get filtered to any group.

To Reproduce No special steps. Open LFG Bulletin Board and wait for a message containing "bot" to be posted and see whether it filters correctly.

Expected behavior Messages with "bot" should get filtered to the "Bastion of Twilight" group when it is enabled. If "Botanica" is also enabled it should filter to both groups.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Additional context I believe it was filtering correctly a couple versions ago. Tried checking changelogs but didn't see any obvious fixes to the issue. A quick hacky solution was editing /dungeons/cata.lua line 147: BOT = 173, -- The Botanica to BOT3 = 173, -- The Botanica ... now it will filter Bastion correctly but not Botanica.

juemrami commented 1 month ago

Do you have "The Botanica" from the burning crusade filters enabled? image

If so, its a known issue that keywords cannot share dungeons/categories at the moment. At least not without hardcoded edge case handling for each one, see Deadmines/Dire Maul and how they share "dm", or how all the Scarlet Monestary wings share "SM".

Its fine for the couple of edge cases the addon was originally designed around from classic era, but theres alot more conflicts adding BC through Cata dungeons in the mix.

See #32

knobs-afk commented 1 month ago

I have Botanica disabled and Bastion of Twilight enabled. "Bot" does not get filtered to any group. Other keywords like "bot10" or "bot25" do work.

juemrami commented 1 month ago

Alright @knobs-afk , i'll took a deeper look today.

Your right, it looks like the shared tag of "bot" for BOT overrides the BOT2 one.

Havent had much time recently, but i think i can bandage this.

Surprised it was not reported earlier. This seems like it should have been broken since cataclysm support was released lol