search

Vysp3r / ProtonPlus

A modern compatibility tools manager for Linux.
GNU General Public License v3.0
237 stars 12 forks source link

[BUG] Can't see installed only proton verions. #162

Closed ecabott closed 10 months ago

ecabott commented 11 months ago

Screenshot from 2023-11-25 22-01-49

Just keeps spinning.

Also, I think a separate installed tab would be better than clicking every proton variants to see if there are installed versions.

Vysp3r commented 11 months ago

Could you make a quick drawing of what you would want the UI to look like? I can't seem to picture what you said in my head so that would help me a lot.

ecabott commented 11 months ago

Instead of listing every detected client on left side like steam, lutris, etc, make it a drop down menu where it lists all the detected clients. Then on the left side below the selected client, show installed protons of the selected client. aa Kind of like this.

ChrisLauinger77 commented 11 months ago

Installed only does also not work for me. It just shows the spinner and nothing happens. I like the propsed idea.

Vysp3r commented 11 months ago

Must have messed something up in the last update for the installed only option not working. As for your idea, I will try it to see if I like it or not. I'll keep you up to date.

Vysp3r commented 10 months ago

image

Here's a sneak peak :)

ChrisLauinger77 commented 10 months ago

Awesome !

Vysp3r commented 10 months ago

So after working on this I came to the realization that we can't really know what's installed that way since we don't know from what runner the release is from. For Proton-GE it's easy since the name is straightforward, but for the majority of them it's not. I could of course add some separators and titles so that you know where it comes from, but that would make that part of the UI really heavy in my opinion.

On top of that it would require me to rewrite a lot of the backend so that the releases from the sidebar are the same and not a copy since otherwise there's no way for the release in the sidebar to know that it was deleted from the right part and vice-versa. The other option would be to add some timers that would check on each side if they're still installed, but that would be heavy on the system for not a lot of gains.

All of that to say that I will not be following with that request since I have other projects I want to work on and don't want to spend days rewriting the backend another time.

I kept the code in https://github.com/Vysp3r/ProtonPlus/tree/sidebar-rework in case anyone want to finish it or if I feel like working on it at some point.

Forgot to say that I fixed the installed releases not loading and will post an update soon for that.