VzBoT3D / docs

VzBot Documentation
https://docs.vzbot.org/
13 stars 23 forks source link

Make /EzVz and /ezvz links legacy intercompatible #99

Open HumbleDeer opened 11 months ago

HumbleDeer commented 11 months ago

cherry-pick from pull request #93 "Minor fixes to documentation STL's and text" ...
... to a new PR so it can either stay open or be handled separately from the other minor fixes as those minor fixes turned out to not be so minor after all.

To view the files changed in this PR, please see https://github.com/VzBoT3D/docs/pull/99/files

The contents of this PR are as follows:

HumbleDeer commented 11 months ago

I'd like both @pbsuper and @StaticFX 's (positive) review on this PR before merging.

HumbleDeer commented 11 months ago

@tehmaze Just confirming you've also checked the contents of these changes? The topic was a bit controversial for a hot second.

tehmaze commented 11 months ago

Confirmed that all the old and new links sort-of work as expected (in that they generate the correct page contents, but I had somehow expected to be redirected). All in all, good enough for now.

HumbleDeer commented 11 months ago

Confirmed that all the old and new links sort-of work as expected (in that they generate the correct page contents, but I had somehow expected to be redirected). All in all, good enough for now.

Were there pages that didn't redirect as expected, then? Did you test this with a local deployment?

Edit: I just checked with a local deployment and it looks like all the redirects work. I did also, during this, discover I didn't change any of the URL's that link to /EzVz pages but that's also the only reason I could see the redirects at work, working properly. I'll try and fix these links soon ish, hopefully. This is implemented in a succeeding commit.

Do we merge this and put those fixed text links in a new PR, or fix those in here?