search

W4RH4WK / Debloat-Windows-10

A Collection of Scripts Which Disable / Remove Windows 10 Features and Apps
Other
6.03k stars 853 forks source link

Recommendation: Move the DNS/IPs out of hardcoded variables and into their own separate text files #301

Open yllekz opened 2 years ago

yllekz commented 2 years ago

I'm not sure if this repo is maintained anymore, but just from a QoL/best practice perspective, I found it interesting that the server names and IPs were hardcoded into the PowerShell scripts. This makes it difficult to read the raw data if one wanted to say, import the list into Pi-Hole and block the servers from the network. From a maintenance perspective, it also separates the script's functional portions from the ephemeral data (i.e., the ever-changing servers/IPs).

Could it be possible to move the server names/IPs specified in the debloat ps1 files to their own separate and sanitized text files?

W4RH4WK commented 2 years ago

It's only barely maintained at this point since I lack the time to adapt existing code and test new additions.

It's certainly possible to read the ip/domain lists from an external file, next to the scripts.

If somebody gives me a PR that adjusts the code accordingly, I'd be happy to merge it.