WAM2layers / Moisture_tracking_intercomparison

Apache License 2.0
4 stars 0 forks source link

Lessons learned and where to go now #42

Open Peter9192 opened 5 months ago

Peter9192 commented 5 months ago

Hi all,

Today I felt we spent quite some time on reading in the data. We got into the habit of sharing some of our code, first through pasting it in GitHub issues, then by opening a pull request (#40).

One thing we learned is that, while it's okay to update the data, it's annoying of the filenames, or the variable names in the files, change. Also, we realized that not all data had the same conventions for naming of and direction of coordinated.

I think we can take this a few steps further. Here are some ideas:

from leiden-mt import list_models, load_data, plot_difference

list_models
# prints list of models

# load all data in one go, or perhaps have several commanda for different views of the data
ds = load_data(model='all')

# Have some utilities available
plot_difference(ds, model1='wam2layers', model2='lagranto-watersip')

The notebooks could then be generated with the functions in this package. We can make the package pip-installable.

I'd be happy to make a start with this, or help others that want to give it a go.