Open apalarcon opened 5 months ago
Thanks for this! It works for me except for the global case, but now there is actually a lot of duplicate code in Functions.py. I think this needs to be cleaned up before merging.
A few other comments:
- There is a mixture of white spaces and tabs in Functions.py which is not ideal. I would stick with one type of indentation (personally I favor white spaces).
The best practice is to use whitespace indeed (see the Python Style guide). It is quite useful to use an automatic code formatter like ruff or black. If we all agree to use ruff, this would also help to keep commits and pull requests free of formatting changes, so we can focus on the code that changed.
I took the liberty to run ruff
and commit the changes to this branch. You can see that the diff is quite big, this is because ruff applies many formatting rules at once.
I have added the functions for the plotting _cases.py script. Note that I didn't overwrite the changes from #72.