search

WASasquatch / FreeU_Advanced

FreeU - Free Lunch, and Dinner.
MIT License
109 stars 11 forks source link

Fix crash on accessing default_image_only_indicator #9

Closed blepping closed 8 months ago

blepping commented 8 months ago

recent commit https://github.com/comfyanonymous/ComfyUI/commit/cb7c3a2921cfc0805be0229b4634e1143d60e6fe removed the default_image_only_indicator attribute. this pull uses getattr to access it with a default value so it should be backwards compatible with revisions where the attribute actually exists/was required.

LiJT commented 8 months ago

Please review it!!!!

BigUncle commented 8 months ago

@blepping, thank you to fix it. @WASasquatch, please review it! +1

blepping commented 8 months ago

thank you to fix it. [...], please review it! +1

unfortunately they haven't been active on GitHub for about a month so don't hold your breath. in the mean time, people can use this pull.

if you don't care about compatibility with older versions of ComfyUI (before the change that broke stuff) you can just change nodes.py line 159 from:

image_only_indicator = kwargs.get("image_only_indicator", self.default_image_only_indicator)

to

image_only_indicator = kwargs.get("image_only_indicator")
BigUncle commented 8 months ago

thank you to fix it. [...], please review it! +1

unfortunately they haven't been active on GitHub for about a month so don't hold your breath. in the mean time, people can use this pull.

if you don't care about compatibility with older versions of ComfyUI (before the change that broke stuff) you can just change nodes.py line 159 from:


image_only_indicator = kwargs.get("image_only_indicator", self.default_image_only_indicator)

to


image_only_indicator = kwargs.get("image_only_indicator")

I have temporarily modified it according to your PR. It works. Thank you again!

WAS-PlaiLabs commented 8 months ago

Thanks for the PR, sorry it took a bit. Been so busy, and for some reason half of GitHub notifications come in forum box vs my main box.

BigUncle commented 8 months ago

@WASasquatch Thanks you!