Open GalaxyTimeMachine opened 1 year ago
Oh thanks for pointing this out. Been trying to port all the image nodes and wondering if I forgot any.
Should be patched: https://github.com/WASasquatch/was-node-suite-comfyui/commit/d64cbc1fefe9097c01c860fe89c3c6dae69f2862 Go ahead and git pull
or update with Manager.
Now it doesn't work with single images either.
Traceback (most recent call last):
File "F:\ComfyUI_windows_portable\ComfyUI\execution.py", line 144, in recursive_execute
output_data, output_ui = get_output_data(obj, input_data_all)
File "F:\ComfyUI_windows_portable\ComfyUI\execution.py", line 74, in get_output_data
return_values = map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True)
File "F:\ComfyUI_windows_portable\ComfyUI\execution.py", line 67, in map_node_over_list
results.append(getattr(obj, func)(**slice_dict(input_data_all, i)))
File "F:\ComfyUI_windows_portable\ComfyUI\custom_nodes\was-node-suite-comfyui\WAS_Node_Suite.py", line 2811, in image_style_filter
for img in images:
NameError: name 'images' is not defined
Oh, part of the changes got reverted. Sorry about that. Should be patched now.
Trying to create single image gives me 2048 x 1 pixel width images, when it goes through the filter, and a batch of 2 gives:
Traceback (most recent call last):
File "F:\ComfyUI_windows_portable\ComfyUI\execution.py", line 144, in recursive_execute
output_data, output_ui = get_output_data(obj, input_data_all)
File "F:\ComfyUI_windows_portable\ComfyUI\execution.py", line 74, in get_output_data
return_values = map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True)
File "F:\ComfyUI_windows_portable\ComfyUI\execution.py", line 67, in map_node_over_list
results.append(getattr(obj, func)(**slice_dict(input_data_all, i)))
File "F:\ComfyUI_windows_portable\ComfyUI\custom_nodes\was-node-suite-comfyui\WAS_Node_Suite.py", line 2867, in image_style_filter
tensors.append(img)
AttributeError: 'Tensor' object has no attribute 'append'
Jesus.
Update again.
It still creates multiple 1 pixel width images
It's working for me. What are you inputting into it?
The image output from "Ultimate SD Upscaler".
I used it like that before I reported it didn't work with batches, without any problem. This behaviour started after you made changes to fix the batch issue.
That's cause it was using tensor regardless of batches, but ultimate SD Upscaler is not outputting correct ComfyUI image format. Even a single image must be batched.
Output from the upscaler to save image and a preview window look normal to me. If I put the style filter between them, then it goes wrong.
Not sure. I don't support other custom_nodes for obvious reasons. Did you actually update WAS-NS, or just getting the previous issue?
I had updated, but just noticed another update today...still no improvement, though. I even tried it on a different, simpler workflow, with no upscaler, and I get the same problem. It just comes out of the decoder, into the style filter and then to a preview:
The Image Style Filter node works fine with individual image generations, but it fails if there is ever more than 1 in a batch.