Open AntitrustEnthusiast opened 1 year ago
Thanks for the quick fix! Confirmed working for embeddings in the root stable-diffusion-webui/embeddings
folder.
There is one minor issue, not sure I'd even call it a bug. And it may not be worth the complexity required to fix it.
Basically: the built-in ComfyUI text encoder will find embedding:laugh512
whether it's in either of these folders:
stable-diffusion-webui/embeddings
stable-diffusion-webui/embeddings/concepts
Allowing users to sort their embeddings by concept/style/etc.But Text Parse A1111 Embeddings
only seems to check the root directory. Possibly true of the ComfyUI/models/embeddings
folder too, but I haven't checked. If fixed, it would mean fully compatible prompts between A1111 and ComfyUI outside LORAs.
No worries if it's out of scope, this issue can be closed if so!
I'll probably have to write out the logic myself. Comfy is lazy on adding useful tools for developers.
ComfyUI has a very useful feature to share model directories with A1111, saving huge amounts of disk space for large model collections.
example
extra_model_paths.yaml
placed in the root ComfyUI directory.When you do this, ComfyUI will properly find embeddings in the stable-diffusion-webui directory. But the
Text Parse A1111 Embeddings
node doesn't seem to find them. It only works if I manually copy the embedding to theComfyUI/models/embeddings
directory.If possible, please support this extra config option to avoid having to duplicate/hardlink embedding directories. Thanks!
Steps to reproduce:
extra_model_paths.yaml
, with correct value forbase_path
stable-diffusion-webui/embeddings
, and a different embedding toComfyUI/models/embeddings
Text Parse A1111 Embeddings
Expected Results:
Text Parse A1111 Embeddings
finds the embeddings inComfyUI/models/embeddings
andstable-diffusion-webui/embeddings
Actual Results:
Text Parse A1111 Embeddings
only finds embeddings inComfyUI/models/embeddings