search

WASasquatch / was-node-suite-comfyui

An extensive node suite for ComfyUI with over 210 new nodes
MIT License
1.15k stars 170 forks source link

Nodes get stuck to cursor when connecting to or from input side of WAS text nodes #144

Closed Waiwei8k closed 1 year ago

Waiwei8k commented 1 year ago

Running was-node-suite on ComfyUI in an install with only Comfy, node manager and this node pack on Python 3.11.4 on Kubuntu 22.04, I get the following issue:

The standard Comfy nodes work fine, allowing me to freely connect between compatible ports on nodes. I want to add some WAS text processing nodes. After adding the text find and replace node, I try to connect it to the built in default text box. No matter which way I connect (text to find and replace or find and replace to text), the connecting line is drawn, but when I click on the destination node, it gets grabbed by the mouse and I can't put it down after. I have to reload the page or delete the node to fix things. This happens with the connections on the left of the was node. Those on the right work fine.

Waiwei8k commented 1 year ago

Loading: ComfyUI-Manager (V0.15.1)

ComfyUI Revision: 1218 [c910b4a0]

was-node-suite-comfyui$ git log -1 commit ab454b1c9a5f00fc8b41b91a7ea94d60d901ce50 (HEAD -> main, origin/main, origin/HEAD) Author: Jordan Thompson jordanslost@gmail.com Date: Thu Jul 27 10:38:42 2023 -0700

MoonRide303 commented 1 year ago

Same problem here - I wanted to use WAS for text concatenation, but it doesn't work (latest version of both ComfyUI and WAS) - connections cannot be made, and native ComfyUI nodes stick to the cursor, instead (only page reload helps).

WASasquatch commented 1 year ago

WAS-NS doesn't really support Python 3.11. It uses older AI tools based around colabs for 3.8,3.9, the fact they work on 3.10 is great but 3.11 is pushing it. However this is just a node pack. It in no way affects the front end so that sounds like a bug with it handling custom data types. Make a report on ComfyUI

MoonRide303 commented 1 year ago

@WASasquatch In my case it happens with Python 3.10.11 (Anaconda for Windows).

Waiwei8k commented 1 year ago

Thanks for the feedback. I'm away for a few days. I'll look at getting the report in on Comfy when I get back.

WASasquatch commented 1 year ago

@WASasquatch In my case it happens with Python 3.10.11 (Anaconda for Windows).

I wasn't referring the the error in general but that you may run into more issues.

WASasquatch commented 1 year ago

I believe this issue has been resolved in base ComfyUI.