search

WASasquatch / was-node-suite-comfyui

An extensive node suite for ComfyUI with over 210 new nodes
MIT License
1.15k stars 170 forks source link

Image Save: Embed workflow does not work for jpeg or webp #148

Closed mattymatty closed 1 year ago

mattymatty commented 1 year ago

Image Save Node: Embed workflow does not work for jpeg or webp

it DOES work for png.

mattymatty commented 1 year ago

This version of save as webp works for embedding the workflow: https://github.com/Kaharos94/ComfyUI-Saveaswebp

WASasquatch commented 1 year ago

ComfyUI only reads PNG workflows, and I do not deploy any custom modifications to the front end. They are all done in hacky unofficial ways.

mattymatty commented 1 year ago

That's not correct. ConfyUI 100% reads webp metadata

WASasquatch commented 1 year ago

That's not correct. ConfyUI 100% reads webp metadata

If so, that is relatively new, as it's a common discussion in Element. Are you sure you don't have Mike's extension that adds webp drag drag support? Even the readme still only lists PNG.

If you can link the source code in ComfyUI I can see about adding support for it.

Seems to be, according to vanilla, base ComfyUI, it still only saves embeded PNG images. Hard coded. https://github.com/comfyanonymous/ComfyUI/blob/master/nodes.py#L1230

The loading happens here, which also appears to be PNG only: https://github.com/comfyanonymous/ComfyUI/blob/18b0b9bbc4d31f2224f94928ef8b5f7638126207/web/scripts/app.js#L1463-L1489

mattymatty commented 1 year ago

You are correct. This https://github.com/Kaharos94/ComfyUI-Saveaswebp both saves metadata to webp and also loads it.