search

WASasquatch / was-node-suite-comfyui

An extensive node suite for ComfyUI with over 210 new nodes
MIT License
1.15k stars 170 forks source link

Write to video #162

Open AIMusicExperiment opened 1 year ago

AIMusicExperiment commented 1 year ago

I'm really excited to use some of you nodes, but as with most developers you have offered very little in the way of documentation. When using the write to video node, using a batch from your batch loader. I get a resize error. Can you enlighten me as to what I'm doing incorrectly? The same files work just fine with the create a video from a path node. But for this workflow that isn't ideal. I wish to generate an image and have it write to a video, so that when the batch is done I have a video. Can you help me out? Thanks!

WASasquatch commented 1 year ago

That's the goal of the node. But without the error, workflow with what you're actually doing, it's hard to say.

Ferniclestix commented 1 year ago

https://drive.google.com/file/d/1iSCt9_YFzHtOzBOaRcvk0d8Dzg2mMuKy/view?usp=sharing Capture happens when using H.264 with this setup. Was having trouble getting ffmpeg installed but thankfully I realized you need to double the \ in the path, suggest you append this to the video node section so people don't try just copy paste path.

havent got it working, but this would be much more useful if we don't have to use comfy batches to do this. workflow queue should also be an option in case you just want to make single fame ajustments.

WASasquatch commented 1 year ago

I can't reproduce this with my own images in your workflow.

Either a image is broken, corrupted somehow, or maybe your opencv installation is bugged, or wrong version.

Ferniclestix commented 1 year ago

yeah, pretty sure issue is incorrect opencv

WASasquatch commented 1 year ago

Maybe try pip install --force-reinstsll --update opencv-python-headless[ffmpeg] on your ComfyUI python environment.

Ferniclestix commented 1 year ago

Installing custom comfy node ... Installing with ComfyUI Portable Collecting opencv-python-headless[ffmpeg] Obtaining dependency information for opencv-python-headless[ffmpeg] from https://files.pythonhosted.org/packages/70/78/7a13730745684584db53e8aa3c3bd84beef2dcb32bebf627bda0d6df461e/opencv_python_headless-4.8.0.76-cp37-abi3-win_amd64.whl.metadata Using cached opencv_python_headless-4.8.0.76-cp37-abi3-win_amd64.whl.metadata (20 kB) WARNING: opencv-python-headless 4.8.0.76 does not provide the extra 'ffmpeg' Collecting numpy>=1.21.2 (from opencv-python-headless[ffmpeg]) Obtaining dependency information for numpy>=1.21.2 from https://files.pythonhosted.org/packages/b7/db/4d37359e2c9cf8bf071c08b8a6f7374648a5ab2e76e2e22e3b808f81d507/numpy-1.25.2-cp310-cp310-win_amd64.whl.metadata Using cached numpy-1.25.2-cp310-cp310-win_amd64.whl.metadata (5.7 kB) Using cached numpy-1.25.2-cp310-cp310-win_amd64.whl (15.6 MB) Using cached opencv_python_headless-4.8.0.76-cp37-abi3-win_amd64.whl (38.0 MB) DEPRECATION: torchsde 0.2.5 has a non-standard dependency specifier numpy>=1.19.*; python_version >= "3.7". pip 23.3 will enforce this behaviour change. A possible replacement is to upgrade to a newer version of torchsde or contact the author to suggest that they release a version with a conforming dependency specifiers. Discussion can be found at https://github.com/pypa/pip/issues/12063 Installing collected packages: numpy, opencv-python-headless Attempting uninstall: numpy Found existing installation: numpy 1.23.5 Uninstalling numpy-1.23.5: Successfully uninstalled numpy-1.23.5 WARNING: The script f2py.exe is installed in 'D:\othercomfy\origin\ComfyUI_windows_portable_test\python_embeded\Scripts' which is not on PATH. Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location. ERROR: Could not install packages due to an OSError: [WinError 5] Access is denied: 'D:\othercomfy\origin\ComfyUI_windows_portable_test\python_embeded\Lib\site-packages\~umpy\.libs\libopenblas.FB5AE2TYXYH2IJRDKGDGQ3XBKLKTF43H.gfortran-win_amd64.dll' Consider using the --user option or check the permissions.

Nope Press any key to continue . . .

I love python so much! (screeeeeeeee)

Ferniclestix commented 1 year ago

annnd yep, broke comfyui

WASasquatch commented 1 year ago

Did you add the paths it tells you to your PATH environment variable?

According to this post their may be a breaking change in 4.8.0.76 too and .74 may be fix: https://github.com/WASasquatch/was-node-suite-comfyui/issues/168#issuecomment-1686672133

Ferniclestix commented 1 year ago

yeah, fixed path issues, still get torch depreciation though, no idea what thats from, looks like some kind of bug in numpy meta process or something like that. also eventually fixed yeh, had to reinstall with different version.