WASasquatch / was-node-suite-comfyui

An extensive node suite for ComfyUI with over 210 new nodes
MIT License
1.15k stars 170 forks source link

Node Suite not importing after update #168

Open GoldmanOz opened 1 year ago

GoldmanOz commented 1 year ago

I'm running an M1 MacBook Pro and have had no issue with Was Node Suite importing until the last update I did, all my installs have been done through the Manager and until the last I have had no issues...Everything in manager is up to date and telling me all is installed but I'm having problems with this Suit and the Impact Pack now, I know this is not the place to ask about the Impact Pack but thought it might help knowing both will not import now and both are showing as properly installed.. ???

Any ideas would be greatly appreciated...I have done nothing to the original installs other than the Manager updates..

WASasquatch commented 1 year ago

You should be receiving an error in your console if WAS Node Suite wasn't properly loaded. That would be the key to figuring what's wrong.

GoldmanOz commented 1 year ago

This is the only error I can seem to find....???

Was2
WASasquatch commented 1 year ago

Looks like you need to run requirements again

GoldmanOz commented 1 year ago

I navigated to the W-N-S in my terminal and ran 'pip install -r requirements.txt' there...no change when loading Comfy after that..any other possible ideas ???
As I said previous it has been working prior to the last update I did via Manager..

WASasquatch commented 1 year ago

Yeah, Data It has been making changes to ComfyUI Manager, which is not my project.

This is the opencv WAS-NS uses: https://pypi.org/project/opencv-python-headless/ pip install opencv-python-headless[ffmpeg]

Though it's not required unless you're using the video writer nodes. If you aren't using those, you can just install opencv-python https://pypi.org/project/opencv-python/

GoldmanOz commented 1 year ago

No change unfortunately...installed opencv-python, already satisfied...ComfyUI depends so much on your Suit and the Impact Pack it's now lost most of its functionality for me...Not your fault I know but I don't know what to do from here..

WASasquatch commented 1 year ago

You're on linux?

It will say it's satisfied cause it is installed, but may not right version installed so you'll need to uninstall it first.

kronkinatorix commented 1 year ago

I'm having the same issue on linux mint 21 victoria.

trying to pip install opencv-python-headless[ffmpeg]==4.8.0.76" displays:

Requirement already satisfied: opencv-python-headless[ffmpeg]==4.8.0.76 in .........ComfyUI/venv/lib/python3.10/site-packages (4.8.0.76) WARNING: opencv-python-headless 4.8.0.76 does not provide the extra 'ffmpeg' Requirement already satisfied: numpy>=1.17.3 in /............omfyUI/venv/lib/python3.10/site-packages (from opencv-python-headless[ffmpeg]==4.8.0.76) (1.23.5)

uninstalling all install opencv and reinstalling does not fix the issue.

kronkinatorix commented 1 year ago

for anyone else that has the same issue: installing

pip install opencv-python-headless[ffmpeg]==4.8.0.74 appears to have fixed the issue.

WASasquatch commented 1 year ago

So appears to be a change in recent builds of opencv, at least in Linux. May pin it if it has no issues on windows.